Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(492)

Issue 2763333002: Convert device sensors structs from Blink to Chromium naming (Closed)

Created:
3 years, 9 months ago by blundell
Modified:
3 years, 9 months ago
Reviewers:
jam
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, Peter Beverloo, riju_, mac-reviews_chromium.org, jam, timvolodine, mlamouri+watch-blink_chromium.org, blink-reviews, darin-cc_chromium.org, mlamouri+watch-sensors_chromium.org, haraken, jochen+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert device sensors structs from Blink to Chromium naming Followup to https://codereview.chromium.org/2415083002/ that converts the just-moved structs from myCoolNamingStyle to my_cool_naming_style. BUG=612322 Review-Url: https://codereview.chromium.org/2763333002 Cr-Commit-Position: refs/heads/master@{#459045} Committed: https://chromium.googlesource.com/chromium/src/+/188eafdbbbb5bdc32823fb73944abccd2bbda5ed

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+315 lines, -310 lines) Patch
M content/browser/device_sensors/device_sensor_browsertest.cc View 2 chunks +31 lines, -31 lines 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/device_sensors/device_motion_event_pump_unittest.cc View 3 chunks +32 lines, -31 lines 0 comments Download
M content/renderer/device_sensors/device_orientation_event_pump.cc View 1 chunk +8 lines, -8 lines 0 comments Download
M content/renderer/device_sensors/device_orientation_event_pump_unittest.cc View 5 chunks +21 lines, -21 lines 0 comments Download
M content/shell/test_runner/test_runner.cc View 2 chunks +21 lines, -21 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_chromeos.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_default.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_mac.cc View 8 chunks +18 lines, -16 lines 0 comments Download
M device/sensors/data_fetcher_shared_memory_win.cc View 5 chunks +21 lines, -21 lines 0 comments Download
M device/sensors/public/cpp/motion_data.h View 1 chunk +19 lines, -19 lines 0 comments Download
M device/sensors/public/cpp/orientation_data.h View 1 chunk +4 lines, -4 lines 0 comments Download
M device/sensors/sensor_manager_android.cc View 6 chunks +23 lines, -23 lines 0 comments Download
M device/sensors/sensor_manager_android_unittest.cc View 6 chunks +37 lines, -37 lines 0 comments Download
M device/sensors/sensor_manager_chromeos.cc View 4 chunks +12 lines, -12 lines 0 comments Download
M device/sensors/sensor_manager_chromeos_unittest.cc View 7 chunks +47 lines, -47 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceMotionData.cpp View 1 1 chunk +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/device_orientation/DeviceOrientationData.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
blundell
3 years, 9 months ago (2017-03-22 17:21:19 UTC) #4
jam
lgtm
3 years, 9 months ago (2017-03-23 00:27:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763333002/1
3 years, 9 months ago (2017-03-23 09:35:51 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/392703)
3 years, 9 months ago (2017-03-23 09:42:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763333002/20001
3 years, 9 months ago (2017-03-23 09:59:59 UTC) #14
commit-bot: I haz the power
3 years, 9 months ago (2017-03-23 11:19:59 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/188eafdbbbb5bdc32823fb73944a...

Powered by Google App Engine
This is Rietveld 408576698