Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1239)

Unified Diff: content/renderer/device_sensors/device_orientation_event_pump_unittest.cc

Issue 2763333002: Convert device sensors structs from Blink to Chromium naming (Closed)
Patch Set: Rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/device_sensors/device_orientation_event_pump_unittest.cc
diff --git a/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc b/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc
index fda6372a15cd51fbc5dfe2b4ea9b75fe417b9e18..ba1067cb59615b3e27312c5aeaca183b251335aa 100644
--- a/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc
+++ b/content/renderer/device_sensors/device_orientation_event_pump_unittest.cc
@@ -88,17 +88,17 @@ class DeviceOrientationEventPumpTest : public testing::Test {
void InitBuffer() {
device::OrientationData& data = buffer()->data;
data.alpha = 1;
- data.hasAlpha = true;
+ data.has_alpha = true;
data.beta = 2;
- data.hasBeta = true;
+ data.has_beta = true;
data.gamma = 3;
- data.hasGamma = true;
- data.allAvailableSensorsAreActive = true;
+ data.has_gamma = true;
+ data.all_available_sensors_are_active = true;
}
void InitBufferNoData() {
device::OrientationData& data = buffer()->data;
- data.allAvailableSensorsAreActive = true;
+ data.all_available_sensors_are_active = true;
}
MockDeviceOrientationListener* listener() { return listener_.get(); }
@@ -133,13 +133,13 @@ TEST_F(DeviceOrientationEventPumpTest, DidStartPolling) {
const device::OrientationData& received_data = listener()->data();
EXPECT_TRUE(listener()->did_change_device_orientation());
- EXPECT_TRUE(received_data.allAvailableSensorsAreActive);
+ EXPECT_TRUE(received_data.all_available_sensors_are_active);
EXPECT_EQ(1, static_cast<double>(received_data.alpha));
- EXPECT_TRUE(received_data.hasAlpha);
+ EXPECT_TRUE(received_data.has_alpha);
EXPECT_EQ(2, static_cast<double>(received_data.beta));
- EXPECT_TRUE(received_data.hasBeta);
+ EXPECT_TRUE(received_data.has_beta);
EXPECT_EQ(3, static_cast<double>(received_data.gamma));
- EXPECT_TRUE(received_data.hasGamma);
+ EXPECT_TRUE(received_data.has_gamma);
}
TEST_F(DeviceOrientationEventPumpTest, FireAllNullEvent) {
@@ -151,10 +151,10 @@ TEST_F(DeviceOrientationEventPumpTest, FireAllNullEvent) {
const device::OrientationData& received_data = listener()->data();
EXPECT_TRUE(listener()->did_change_device_orientation());
- EXPECT_TRUE(received_data.allAvailableSensorsAreActive);
- EXPECT_FALSE(received_data.hasAlpha);
- EXPECT_FALSE(received_data.hasBeta);
- EXPECT_FALSE(received_data.hasGamma);
+ EXPECT_TRUE(received_data.all_available_sensors_are_active);
+ EXPECT_FALSE(received_data.has_alpha);
+ EXPECT_FALSE(received_data.has_beta);
+ EXPECT_FALSE(received_data.has_gamma);
}
TEST_F(DeviceOrientationEventPumpTest, UpdateRespectsOrientationThreshold) {
@@ -166,13 +166,13 @@ TEST_F(DeviceOrientationEventPumpTest, UpdateRespectsOrientationThreshold) {
const device::OrientationData& received_data = listener()->data();
EXPECT_TRUE(listener()->did_change_device_orientation());
- EXPECT_TRUE(received_data.allAvailableSensorsAreActive);
+ EXPECT_TRUE(received_data.all_available_sensors_are_active);
EXPECT_EQ(1, static_cast<double>(received_data.alpha));
- EXPECT_TRUE(received_data.hasAlpha);
+ EXPECT_TRUE(received_data.has_alpha);
EXPECT_EQ(2, static_cast<double>(received_data.beta));
- EXPECT_TRUE(received_data.hasBeta);
+ EXPECT_TRUE(received_data.has_beta);
EXPECT_EQ(3, static_cast<double>(received_data.gamma));
- EXPECT_TRUE(received_data.hasGamma);
+ EXPECT_TRUE(received_data.has_gamma);
buffer()->data.alpha =
1 + DeviceOrientationEventPump::kOrientationThreshold / 2.0;
@@ -187,13 +187,13 @@ TEST_F(DeviceOrientationEventPumpTest, UpdateRespectsOrientationThreshold) {
base::RunLoop().Run();
EXPECT_FALSE(listener()->did_change_device_orientation());
- EXPECT_TRUE(received_data.allAvailableSensorsAreActive);
+ EXPECT_TRUE(received_data.all_available_sensors_are_active);
EXPECT_EQ(1, static_cast<double>(received_data.alpha));
- EXPECT_TRUE(received_data.hasAlpha);
+ EXPECT_TRUE(received_data.has_alpha);
EXPECT_EQ(2, static_cast<double>(received_data.beta));
- EXPECT_TRUE(received_data.hasBeta);
+ EXPECT_TRUE(received_data.has_beta);
EXPECT_EQ(3, static_cast<double>(received_data.gamma));
- EXPECT_TRUE(received_data.hasGamma);
+ EXPECT_TRUE(received_data.has_gamma);
buffer()->data.alpha =
1 + DeviceOrientationEventPump::kOrientationThreshold;
« no previous file with comments | « content/renderer/device_sensors/device_orientation_event_pump.cc ('k') | content/shell/test_runner/test_runner.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698