[instrumentation] Generalize instrumentation to be used beyond the core layer

[instrumentation] Generalize instrumentation to be used beyond the core layer

Changes made in the patch:
- Code generator is made more generic, so it can generate code for core as well as for platform.
- Introduced instrumenting agents for FetchContext in the platform
- Introduced PlatformTraceEventsAgent what listens to PlatformSendRequest probe and produces corresponsing trace events.


BUG=695625
Review-Url: https://codereview.chromium.org/2760363002
Cr-Commit-Position: refs/heads/master@{#459183}
Committed: https://chromium.googlesource.com/chromium/src/+/480ae9f27c791955a96bbdb7b9db090ec57db4ab

[alph, 2017-03-21 18:02:54]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[alph, 2017-03-21 18:03:27]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-21 18:04:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 19:43:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 19:43:20]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2017-03-22 01:39:28]

Please don't instantiate this in platform just yet, make it a pure move.

https://codereview.chromium.org/2760363002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalFrame.h (right):

https://codereview.chromium.org/2760363002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalFrame.h:167:
InspectorInstrumentationAgents* instrumentingAgents() {
CoreProbeSink

https://codereview.chromium.org/2760363002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
(right):

https://codereview.chromium.org/2760363002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl:354:
#define PROBE_EXPORT CORE_EXPORT
This is codegen config.

[pfeldman, 2017-03-22 01:52:35]

lgtm

[alph, 2017-03-22 21:16:02]

Description was changed from

==========
[instrumentation] Generalize instrumentation to be used beyond the core layer

Introduce instrumentation for platform.

BUG=695625
==========

to

==========
[instrumentation] Generalize instrumentation to be used beyond the core layer

Changes made in the patch:
- Code generator is made more generic, so it can generate code for core as well
as for platform.
- Introduced instrumenting agents for FetchContext in the platform
- Introduced PlatformTraceEventsAgent what listens to PlatformSendRequest probe
and produces corresponsing trace events.


BUG=695625
==========

[alph, 2017-03-22 22:09:04]

On 2017/03/22 01:39:28, pfeldman wrote:
> Please don't instantiate this in platform just yet, make it a pure move.

This is just a move. The instrumentation we have in platform is not changed yet.

[alph, 2017-03-22 22:09:16]

https://codereview.chromium.org/2760363002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/frame/LocalFrame.h (right):

https://codereview.chromium.org/2760363002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/frame/LocalFrame.h:167:
InspectorInstrumentationAgents* instrumentingAgents() {
On 2017/03/22 01:39:28, pfeldman wrote:
> CoreProbeSink

I'll do the InspectorInsrumentation -> CoreProbes rename in a separate patch.
It's pretty mechanical and touches lots of files.

https://codereview.chromium.org/2760363002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
(right):

https://codereview.chromium.org/2760363002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl:354:
#define PROBE_EXPORT CORE_EXPORT
On 2017/03/22 01:39:28, pfeldman wrote:
> This is codegen config.

An upcoming patch will introduce a config. Currently everything about the probes
is in the idl.

[alph, 2017-03-22 22:09:26]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-22 22:10:24]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 23:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 23:08:41]

Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[alph, 2017-03-23 19:07:18]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2017-03-23 19:07:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-23 19:42:41]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1490296038495750, "parent_rev":
"c2637be18c2e52da142d6cbf646ab82045e13218", "commit_rev":
"480ae9f27c791955a96bbdb7b9db090ec57db4ab"}

[commit-bot: I haz the power, 2017-03-23 19:43:31]

Description was changed from

==========
[instrumentation] Generalize instrumentation to be used beyond the core layer

Changes made in the patch:
- Code generator is made more generic, so it can generate code for core as well
as for platform.
- Introduced instrumenting agents for FetchContext in the platform
- Introduced PlatformTraceEventsAgent what listens to PlatformSendRequest probe
and produces corresponsing trace events.


BUG=695625
==========

to

==========
[instrumentation] Generalize instrumentation to be used beyond the core layer

Changes made in the patch:
- Code generator is made more generic, so it can generate code for core as well
as for platform.
- Introduced instrumenting agents for FetchContext in the platform
- Introduced PlatformTraceEventsAgent what listens to PlatformSendRequest probe
and produces corresponsing trace events.


BUG=695625

Review-Url: https://codereview.chromium.org/2760363002
Cr-Commit-Position: refs/heads/master@{#459183}
Committed:
https://chromium.googlesource.com/chromium/src/+/480ae9f27c791955a96bbdb7b9db...
==========

[commit-bot: I haz the power, 2017-03-23 19:43:33]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/480ae9f27c791955a96bbdb7b9db...