[instrumentation] Generalize instrumentation to be used beyond the core layer

third_party/WebKit/Source/core/frame/LocalFrame.h

 /*
  * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
  *                     1999-2001 Lars Knoll <knoll@kde.org>
  *                     1999-2001 Antti Koivisto <koivisto@kde.org>
  *                     2000-2001 Simon Hausmann <hausmann@kde.org>
  *                     2000-2001 Dirk Mueller <mueller@kde.org>
  *                     2000 Stefan Schimanski <1Stein@gmx.de>
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
  * reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
@@ skipping 41 matching lines @@
 class EditingAlgorithm;
 class Element;
 template <typename Strategy>
 class EphemeralRangeTemplate;
 class EventHandler;
 class FloatSize;
 class FrameConsole;
 class FrameSelection;
 class FrameView;
 class InputMethodController;
-class InstrumentingAgents;
+class InspectorInstrumentationAgents;
 class InterfaceProvider;
 class InterfaceRegistry;
 class IntPoint;
 class IntSize;
 class LayoutView;
 class LayoutViewItem;
 class LocalDOMWindow;
 class LocalWindowProxy;
 class LocalFrameClient;
 class NavigationScheduler;
@@ skipping 84 matching lines @@
   LocalFrame* localFrameRoot();
 
   // Note that the result of this function should not be cached: a frame is
   // not necessarily detached when it is navigated, so the return value can
   // change.
   // In addition, this function will always return true for a detached frame.
   // TODO(dcheng): Move this to LocalDOMWindow and figure out the right
   // behavior for detached windows.
   bool isCrossOriginSubframe() const;
 
-  InstrumentingAgents* instrumentingAgents() {
+  InspectorInstrumentationAgents* instrumentingAgents() {

[pfeldman, 2017/03/22 01:39:28]

CoreProbeSink

[alph, 2017/03/22 22:09:15]

I'll do the InspectorInsrumentation -> CoreProbes rename in a separate patch.
It's pretty mechanical and touches lots of files.

     return m_instrumentingAgents.get();
   }
 
   // =========================================================================
   // All public functions below this point are candidates to move out of
   // LocalFrame into another class.
 
   // See GraphicsLayerClient.h for accepted flags.
   String layerTreeAsText(unsigned flags = 0) const;
 
@@ skipping 85 matching lines @@
   const Member<FrameConsole> m_console;
   const Member<InputMethodController> m_inputMethodController;
 
   int m_navigationDisableCount;
 
   float m_pageZoomFactor;
   float m_textZoomFactor;
 
   bool m_inViewSourceMode;
 
-  Member<InstrumentingAgents> m_instrumentingAgents;
+  Member<InspectorInstrumentationAgents> m_instrumentingAgents;
   Member<PerformanceMonitor> m_performanceMonitor;
 
   InterfaceProvider* const m_interfaceProvider;
   InterfaceRegistry* const m_interfaceRegistry;
 };
 
 inline void LocalFrame::init() {
   m_loader.init();
 }
 
@@ skipping 89 matching lines @@
   explicit ScopedFrameBlamer(LocalFrame*);
   ~ScopedFrameBlamer();
 
  private:
   Member<LocalFrame> m_frame;
 };
 
 }  // namespace blink
 
 #endif  // LocalFrame_h