Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1243)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

Issue 2760363002: [instrumentation] Generalize instrumentation to be used beyond the core layer (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
diff --git a/third_party/WebKit/Source/core/inspector/InstrumentingProbes.idl b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
similarity index 98%
rename from third_party/WebKit/Source/core/inspector/InstrumentingProbes.idl
rename to third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
index 9ed6f7148d89d54884d95b96b90af7ae34184985..a0e5f4e9c8f8af83cbb8bd692e7fe6e0eff333ae 100644
--- a/third_party/WebKit/Source/core/inspector/InstrumentingProbes.idl
+++ b/third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl
@@ -44,7 +44,7 @@
* Examples: DOM, Page, Debugger.
*
* paramAttr - optional attribute controlling the parameters handling (one attribute per parameter max).
-* Keep - pass first parameter (used to access the InstrumentingAgents instance) to agents.
+* Keep - pass first parameter (used to access the InspectorInstrumentationAgents instance) to agents.
*
* returnValue: C++ return value. Only "void" and "bool" are supported.
*
@@ -64,6 +64,8 @@ interface InspectorInstrumentation {
#include "core/dom/PseudoElement.h"
#include "core/html/HTMLSlotElement.h"
+#define PROBE_EXPORT CORE_EXPORT
+
class ConsoleMessage;
class HTMLDocumentParser;
class ThreadableLoaderClient;
@@ -348,6 +350,9 @@ class XMLHttpRequest;
}
interface InspectorOverrides {
+
+#define PROBE_EXPORT CORE_EXPORT
pfeldman 2017/03/22 01:39:28 This is codegen config.
alph 2017/03/22 22:09:16 An upcoming patch will introduce a config. Current
+
[CSS]
bool forcePseudoState([Keep] Element* element, CSSSelector::PseudoType pseudoState);

Powered by Google App Engine
This is Rietveld 408576698