[instrumentation] Generalize instrumentation to be used beyond the core layer

third_party/WebKit/Source/core/inspector/InspectorInstrumentation.idl

 /*
 * Copyright (C) 2013 Google Inc. All rights reserved.
 *
 * Redistribution and use in source and binary forms, with or without
 * modification, are permitted provided that the following conditions are
 * met:
 *
 *     * Redistributions of source code must retain the above copyright
 * notice, this list of conditions and the following disclaimer.
 *     * Redistributions in binary form must reproduce the above
@@ skipping 26 matching lines @@
 * The syntax for an instrumentation method is as follows:
 *
 *    [methodAttributes] returnValue methodName([paramAttr1] param1, [paramAttr2] param2, ...)
 *
 * Where:
 *   methodAttributes - optional list of method attributes.
 *       Attributes without "=" are the names of the agents to be invoked.
 *           Examples: DOM, Page, Debugger.
 *
 *   paramAttr - optional attribute controlling the parameters handling (one attribute per parameter max).
-*       Keep - pass first parameter (used to access the InstrumentingAgents instance) to agents.
+*       Keep - pass first parameter (used to access the InspectorInstrumentationAgents instance) to agents.
 *
 *   returnValue: C++ return value. Only "void" and "bool" are supported.
 *
 *   methodName: C++ name for the public instrumentation method and agents methods.
 *
 *   paramList: C++ parameter list with optional names. Names will be deduced from types if omitted but you have to
 *        specify explicit names for multiple parameters of the same type.
 *
 * Parameters with type PassRefPtr<T> are converted to raw pointers,
 * so reference will not be passed or released until all agents are notified.
 */
 
 interface InspectorInstrumentation {
 
 #include "core/animation/Animation.h"
 #include "core/dom/CharacterData.h"
 #include "core/dom/PseudoElement.h"
 #include "core/html/HTMLSlotElement.h"
 
+#define PROBE_EXPORT CORE_EXPORT
+
 class ConsoleMessage;
 class HTMLDocumentParser;
 class ThreadableLoaderClient;
 class WebSocketHandshakeRequest;
 class WebSocketHandshakeResponse;
 class WorkerInspectorProxy;
 class XMLHttpRequest;
 
     [Page, Animation]
     void didClearDocumentOfWindowObject([Keep] LocalFrame*);
@@ skipping 264 matching lines @@
     CallFunction([Keep] ExecutionContext* context, v8::Local<v8::Function> function, int depth = 0);
 
     [Performance, DOMDebugger]
     UserCallback([Keep] ExecutionContext* context, const char* name, const AtomicString& atomicName, bool recurring, EventTarget* eventTarget = nullptr);
 
     [TraceEvents]
     ParseHTML(Document* document, HTMLDocumentParser* parser);
 }
 
 interface InspectorOverrides {
+
+#define PROBE_EXPORT CORE_EXPORT

[pfeldman, 2017/03/22 01:39:28]

This is codegen config.

[alph, 2017/03/22 22:09:16]

An upcoming patch will introduce a config. Currently everything about the probes
is in the idl.

+
     [CSS]
     bool forcePseudoState([Keep] Element* element, CSSSelector::PseudoType pseudoState);
 
     [Worker]
     bool shouldWaitForDebuggerOnWorkerStart(ExecutionContext* context);
 
     [Network]
     bool shouldForceCORSPreflight(Document*);
 
     [Network]
     bool shouldBlockRequest(LocalFrame*, const ResourceRequest&);
 }