Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2760233004: Make all setNeedsReattachLayoutTree happen from updateStyle. (Closed)

Created:
3 years, 9 months ago by rune
Modified:
3 years, 9 months ago
Reviewers:
nainar, esprehn
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Make all setNeedsReattachLayoutTree happen from updateStyle. The setNeedsReattachLayoutTree calls which were done outside of updateStyle were all accompanied by a NeedsReattachStyleChange for the node marking the ancestor chain for recalc. Therefore we can simply mark for re-attachment inside the recalcStyle pass instead. Enforce the invariant by introducing a DCHECK that the we are inside updateStyleAndLayoutTree, and that the shadow DOM distribution is up-to-date. R=nainar@chromium.org,esprehn@chromium.org BUG=595137 Review-Url: https://codereview.chromium.org/2760233004 Cr-Commit-Position: refs/heads/master@{#458683} Committed: https://chromium.googlesource.com/chromium/src/+/d6f8a937c0d8fbfcbdfe7edc93255e454c5de3cf

Patch Set 1 #

Patch Set 2 : Corrected DCHECK condition #

Total comments: 2

Patch Set 3 : Split DCHECK and removed default flag. #

Patch Set 4 : Included https://codereview.chromium.org/2760953003/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M third_party/WebKit/Source/core/dom/ContainerNode.cpp View 2 chunks +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Element.cpp View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/Node.h View 1 2 2 chunks +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp View 1 2 3 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 31 (16 generated)
rune
3 years, 9 months ago (2017-03-21 17:38:57 UTC) #8
esprehn
NeedsReattachLayoutTree is in the default node flags, this patch still leaves every new node as ...
3 years, 9 months ago (2017-03-21 20:59:56 UTC) #9
rune
On 2017/03/21 20:59:56, esprehn wrote: > NeedsReattachLayoutTree is in the default node flags, this patch ...
3 years, 9 months ago (2017-03-21 22:07:44 UTC) #10
rune
https://codereview.chromium.org/2760233004/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp File third_party/WebKit/Source/core/dom/Node.cpp (right): https://codereview.chromium.org/2760233004/diff/20001/third_party/WebKit/Source/core/dom/Node.cpp#newcode728 third_party/WebKit/Source/core/dom/Node.cpp:728: DCHECK(document().inStyleRecalc() && On 2017/03/21 20:59:56, esprehn wrote: > Can ...
3 years, 9 months ago (2017-03-21 22:25:15 UTC) #13
esprehn
lgtm
3 years, 9 months ago (2017-03-21 22:34:17 UTC) #14
rune
On 2017/03/21 22:34:17, esprehn wrote: > lgtm Thanks. This is depending on that other CL. ...
3 years, 9 months ago (2017-03-21 22:39:40 UTC) #15
esprehn
On 2017/03/21 at 22:39:40, rune wrote: > On 2017/03/21 22:34:17, esprehn wrote: > > lgtm ...
3 years, 9 months ago (2017-03-21 22:40:30 UTC) #16
rune
On 2017/03/21 22:40:30, esprehn wrote: > On 2017/03/21 at 22:39:40, rune wrote: > > On ...
3 years, 9 months ago (2017-03-21 22:45:08 UTC) #17
esprehn
lgtm
3 years, 9 months ago (2017-03-21 22:45:28 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760233004/60001
3 years, 9 months ago (2017-03-21 22:46:39 UTC) #20
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xcode-clang/builds/63524)
3 years, 9 months ago (2017-03-21 23:15:18 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760233004/60001
3 years, 9 months ago (2017-03-22 00:30:54 UTC) #24
commit-bot: I haz the power
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_TIMED_OUT, build hasn't started yet, builder ...
3 years, 9 months ago (2017-03-22 02:33:45 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760233004/60001
3 years, 9 months ago (2017-03-22 08:17:25 UTC) #28
commit-bot: I haz the power
3 years, 9 months ago (2017-03-22 08:21:40 UTC) #31
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/d6f8a937c0d8fbfcbdfe7edc9325...

Powered by Google App Engine
This is Rietveld 408576698