third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp - Issue 2760233004: Make all setNeedsReattachLayoutTree happen from updateStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

Issue 2760233004: Make all setNeedsReattachLayoutTree happen from updateStyle. (Closed)

Patch Set: Included https://codereview.chromium.org/2760953003/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

index 3d9959546af7fdaf67bdc20fc745cbb0c3c36731..17ff2f27d5cceb8e53f0b5d5ec21284fa05fd99b 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp

@@ -142,8 +142,11 @@ void ShadowRoot::recalcStyle(StyleRecalcChange change) {

StyleSharingDepthScope sharingScope(*this);

- if (getStyleChangeType() >= SubtreeStyleChange)

+ if (getStyleChangeType() >= SubtreeStyleChange) {

change = Force;

+ if (needsAttach())

+ setNeedsReattachLayoutTree();

+ }

// There's no style to update so just calling recalcStyle means we're updated.

clearNeedsStyleRecalc();

« no previous file with comments | « third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp ('k') | no next file » | no next file with comments »