third_party/WebKit/Source/core/dom/Node.h - Issue 2760233004: Make all setNeedsReattachLayoutTree happen from updateStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Node.h

Issue 2760233004: Make all setNeedsReattachLayoutTree happen from updateStyle. (Closed)

Patch Set: Included https://codereview.chromium.org/2760953003/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/Node.h

diff --git a/third_party/WebKit/Source/core/dom/Node.h b/third_party/WebKit/Source/core/dom/Node.h

index 870742f398f6dbb42f471be00a2b9fb23edcce7d..26d31c6539877182b023e06bb389872ba5388499 100644

--- a/third_party/WebKit/Source/core/dom/Node.h

+++ b/third_party/WebKit/Source/core/dom/Node.h

@@ -822,9 +822,7 @@ class CORE_EXPORT Node : public EventTarget {

NeedsReattachLayoutTree = 1 << 26,

ChildNeedsReattachLayoutTree = 1 << 27,

- DefaultNodeFlags = IsFinishedParsingChildrenFlag |

- NeedsReattachStyleChange |

- NeedsReattachLayoutTree

+ DefaultNodeFlags = IsFinishedParsingChildrenFlag | NeedsReattachStyleChange

};

// 4 bits remaining.

@@ -969,7 +967,6 @@ inline void Node::lazyReattachIfAttached() {

detachLayoutTree(context);

markAncestorsWithChildNeedsStyleRecalc();

- markAncestorsWithChildNeedsReattachLayoutTree();

}

inline bool Node::shouldCallRecalcStyle(StyleRecalcChange change) {