third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp - Issue 2760233004: Make all setNeedsReattachLayoutTree happen from updateStyle.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

Issue 2760233004: Make all setNeedsReattachLayoutTree happen from updateStyle. (Closed)

Patch Set: Included https://codereview.chromium.org/2760953003/ Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

diff --git a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

index c0c743f1052b625e1523afd0309c145ddea9c762..8e5eec4474bb8304ef3ab9d88ba8ad572a34a6c6 100644

--- a/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

+++ b/third_party/WebKit/Source/core/dom/shadow/ElementShadow.cpp

@@ -86,7 +86,6 @@ ShadowRoot& ElementShadow::addShadowRoot(Element& shadowHost,

shadowHost.setNeedsStyleRecalc(

SubtreeStyleChange,

StyleChangeReasonForTracing::create(StyleChangeReason::Shadow));

- shadowRoot->setNeedsReattachLayoutTree();

probe::didPushShadowRoot(&shadowHost, shadowRoot);