Protobuf: Move thread-local global data to globals.cc

Protobuf: Move thread-local global data to globals.cc

This CL is a followup to https://codereview.chromium.org/2756543002/ which moved
all variables in .data and .bss into globals.cc.  However, I overlooked thread-local
variables in .tdata and .tbss.  This CL moves those too.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng
R=pkasting@chromium.org
CC=piman@chromium.org
BUG=703706
Review-Url: https://codereview.chromium.org/2759423004
Cr-Commit-Position: refs/heads/master@{#458677}
Committed: https://chromium.googlesource.com/chromium/src/+/57c80c99d9f3355e5dc1829d0ac2eeffe7cd26b6

[Tom (Use chromium acct), 2017-03-22 03:56:15]

Description was changed from

==========
Protobuf: Move thread-local global data to globals.cc

BUG=
==========

to

==========
Protobuf: Move thread-local global data to globals.cc

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng
BUG=
==========

[Tom (Use chromium acct), 2017-03-22 03:56:18]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 03:57:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2017-03-22 03:57:23]

Description was changed from

==========
Protobuf: Move thread-local global data to globals.cc

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng
BUG=
==========

to

==========
Protobuf: Move thread-local global data to globals.cc

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng
R=pkasting@chromium.org
CC=piman@chromium.org
BUG=703706
==========

[Tom (Use chromium acct), 2017-03-22 03:57:23]

thomasanderson@google.com changed reviewers:
+ pkasting@chromium.org

[Tom (Use chromium acct), 2017-03-22 04:53:52]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 04:54:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Tom (Use chromium acct), 2017-03-22 04:56:23]

Description was changed from

==========
Protobuf: Move thread-local global data to globals.cc

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng
R=pkasting@chromium.org
CC=piman@chromium.org
BUG=703706
==========

to

==========
Protobuf: Move thread-local global data to globals.cc

This CL is a followup to https://codereview.chromium.org/2756543002/ which moved
all variables in .data and .bss into globals.cc.  However, I overlooked
thread-local
variables in .tdata and .tbss.  This CL moves those too.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng
R=pkasting@chromium.org
CC=piman@chromium.org
BUG=703706
==========

[Tom (Use chromium acct), 2017-03-22 05:02:16]

pkasting@ ptal

This should fix a bug where the GPU process fails to launch with is_debug=false,
is_component_build=true

[Tom (Use chromium acct), 2017-03-22 05:02:23]

Patchset #2 (id:20001) has been deleted

[Tom (Use chromium acct), 2017-03-22 05:02:33]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 05:03:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Peter Kasting, 2017-03-22 05:16:40]

LGTM

https://codereview.chromium.org/2759423004/diff/40001/third_party/protobuf/BU...
File third_party/protobuf/BUILD.gn (right):

https://codereview.chromium.org/2759423004/diff/40001/third_party/protobuf/BU...
third_party/protobuf/BUILD.gn:207: public_configs += [ ":protobuf_use_dlls" ]
Dunno that I understand the change to start doing this for Linux

https://codereview.chromium.org/2759423004/diff/40001/third_party/protobuf/RE...
File third_party/protobuf/README.chromium (right):

https://codereview.chromium.org/2759423004/diff/40001/third_party/protobuf/RE...
third_party/protobuf/README.chromium:38: objdump: section '.data' mentioned in a
-j option, but not found in any input file
Does this output need updating?

[Tom (Use chromium acct), 2017-03-22 05:40:50]

https://codereview.chromium.org/2759423004/diff/40001/third_party/protobuf/BU...
File third_party/protobuf/BUILD.gn (right):

https://codereview.chromium.org/2759423004/diff/40001/third_party/protobuf/BU...
third_party/protobuf/BUILD.gn:207: public_configs += [ ":protobuf_use_dlls" ]
On 2017/03/22 05:16:40, Peter Kasting wrote:
> Dunno that I understand the change to start doing this for Linux

cr_thread_cache() has a different definition depending on
defined(USE_PROTOBUF_DLLS), and this makes it so that protobuf_lite and
protobuf_globals are using the same one.

[Tom (Use chromium acct), 2017-03-22 05:42:47]

The CQ bit was checked by thomasanderson@google.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-22 05:43:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 07:21:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-22 07:21:38]

Dry run: This issue passed the CQ dry run.

[Tom (Use chromium acct), 2017-03-22 07:46:44]

The CQ bit was checked by thomasanderson@google.com

[Tom (Use chromium acct), 2017-03-22 07:46:44]

The patchset sent to the CQ was uploaded after l-g-t-m from
pkasting@chromium.org
Link to the patchset: https://codereview.chromium.org/2759423004/#ps60001
(title: "Address pkasting@'s comments")

[commit-bot: I haz the power, 2017-03-22 07:46:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-22 07:51:28]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1490168804137700,
"parent_rev": "37e249b227c29efb3b51f95d83d0a93910ec74de", "commit_rev":
"57c80c99d9f3355e5dc1829d0ac2eeffe7cd26b6"}

[commit-bot: I haz the power, 2017-03-22 07:52:12]

Description was changed from

==========
Protobuf: Move thread-local global data to globals.cc

This CL is a followup to https://codereview.chromium.org/2756543002/ which moved
all variables in .data and .bss into globals.cc.  However, I overlooked
thread-local
variables in .tdata and .tbss.  This CL moves those too.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng
R=pkasting@chromium.org
CC=piman@chromium.org
BUG=703706
==========

to

==========
Protobuf: Move thread-local global data to globals.cc

This CL is a followup to https://codereview.chromium.org/2756543002/ which moved
all variables in .data and .bss into globals.cc.  However, I overlooked
thread-local
variables in .tdata and .tbss.  This CL moves those too.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_dbg_ng;master.tryserver.chromium.mac:mac_chromium_dbg_ng;master.tryserver.chromium.win:win_chromium_dbg_ng
R=pkasting@chromium.org
CC=piman@chromium.org
BUG=703706

Review-Url: https://codereview.chromium.org/2759423004
Cr-Commit-Position: refs/heads/master@{#458677}
Committed:
https://chromium.googlesource.com/chromium/src/+/57c80c99d9f3355e5dc1829d0ac2...
==========

[commit-bot: I haz the power, 2017-03-22 07:52:13]

Committed patchset #3 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/57c80c99d9f3355e5dc1829d0ac2...