Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(114)

Unified Diff: third_party/protobuf/BUILD.gn

Issue 2759423004: Protobuf: Move thread-local global data to globals.cc (Closed)
Patch Set: Address pkasting@'s comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/protobuf/README.chromium » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/protobuf/BUILD.gn
diff --git a/third_party/protobuf/BUILD.gn b/third_party/protobuf/BUILD.gn
index 6fb6d6ad30439ccee3fb4dcac22cec4b90c454f0..829cfdfe9e4df181620c038c5ce8bdde417e890e 100644
--- a/third_party/protobuf/BUILD.gn
+++ b/third_party/protobuf/BUILD.gn
@@ -203,9 +203,11 @@ target(link_target_type, "protobuf_lite") {
}
# Required for component builds. See http://crbug.com/172800.
- if (is_component_build && (!is_linux || is_chromeos)) {
+ if (is_component_build) {
public_configs += [ ":protobuf_use_dlls" ]
- defines = [ "LIBPROTOBUF_EXPORTS" ]
+ if (!is_linux || is_chromeos) {
+ defines = [ "LIBPROTOBUF_EXPORTS" ]
+ }
}
}
« no previous file with comments | « no previous file | third_party/protobuf/README.chromium » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698