third_party/protobuf/README.chromium - Issue 2759423004: Protobuf: Move thread-local global data to globals.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/protobuf/README.chromium

Issue 2759423004: Protobuf: Move thread-local global data to globals.cc (Closed)

Patch Set: Address pkasting@'s comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/protobuf/README.chromium

diff --git a/third_party/protobuf/README.chromium b/third_party/protobuf/README.chromium

index edb4d6f1c58234adf3daceaf8376b142b0117a49..3d69cc4a9b4bdb320ec9dd54297726fa48ae36e1 100644

--- a/third_party/protobuf/README.chromium

+++ b/third_party/protobuf/README.chromium

@@ -29,10 +29,13 @@ Steps used to create the current version:

5. Extract all globals to src/google/protobuf/globals.cc and prefix these

symbols with 'cr_'. On Linux, the command

- $ objdump -t -j.data -j.bss obj/third_party/protobuf/libprotobuf_lite.a

+ $ objdump -t -j.data -j.bss -j.tdata -j.tbss \

+ obj/third_party/protobuf/libprotobuf_lite.a

should produce the output

+ objdump: section '.tbss' mentioned in a -j option, but not found in any input file

+ objdump: section '.tdata' mentioned in a -j option, but not found in any input file

objdump: section '.bss' mentioned in a -j option, but not found in any input file

objdump: section '.data' mentioned in a -j option, but not found in any input file