Protobuf: Move thread-local global data to globals.cc

third_party/protobuf/BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 config("protobuf_config") {
   include_dirs = [ "src" ]
   defines = [
     "GOOGLE_PROTOBUF_NO_RTTI",
     "GOOGLE_PROTOBUF_NO_STATIC_INITIALIZER",
   ]
@@ skipping 185 matching lines @@
 
   cflags = protobuf_lite_cflags
 
   if (is_component_build && is_linux && !is_chromeos) {
     deps += [ ":protobuf_globals" ]
   } else {
     sources += [ "src/google/protobuf/globals.cc" ]
   }
 
   # Required for component builds. See http://crbug.com/172800.
-  if (is_component_build && (!is_linux || is_chromeos)) {
+  if (is_component_build) {
     public_configs += [ ":protobuf_use_dlls" ]

[Peter Kasting, 2017/03/22 05:16:40]

Dunno that I understand the change to start doing this for Linux

[Tom (Use chromium acct), 2017/03/22 05:40:49]

cr_thread_cache() has a different definition depending on
defined(USE_PROTOBUF_DLLS), and this makes it so that protobuf_lite and
protobuf_globals are using the same one.

-    defines = [ "LIBPROTOBUF_EXPORTS" ]
+    if (!is_linux || is_chromeos) {
+      defines = [ "LIBPROTOBUF_EXPORTS" ]
+    }
   }
 }
 
 # This is the full, heavy protobuf lib that's needed for c++ .protos that don't
 # specify the LITE_RUNTIME option. The protocol compiler itself (protoc) falls
 # into that category. Do not use in Chrome code.
 static_library("protobuf_full") {
   # Prevent people from depending on this outside our file.
   visibility = [
     ":*",
@@ skipping 467 matching lines @@
     ":copy_google_protobuf_internal",
     ":copy_six",
   ]
 
   # Targets that depend on this should depend on the copied data files.
   data = get_target_outputs(":copy_google")
   data += get_target_outputs(":copy_six")
   data += get_target_outputs(":copy_google_protobuf")
   data += get_target_outputs(":copy_google_protobuf_internal")
 }