3 years, 9 months ago
(2017-03-20 22:28:49 UTC)
#8
Andrey, could you please take a look?
lushnikov
lgtm https://codereview.chromium.org/2758963002/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js File third_party/WebKit/Source/devtools/front_end/main/Main.js (right): https://codereview.chromium.org/2758963002/diff/1/third_party/WebKit/Source/devtools/front_end/main/Main.js#newcode48 third_party/WebKit/Source/devtools/front_end/main/Main.js:48: resourceTreeModel.reloadPage(hard); (here and in other for-loops): don't you ...
3 years, 9 months ago
(2017-03-20 23:50:09 UTC)
#9
Dry run: Try jobs failed on following builders: linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_tsan_rel_ng/builds/36583)
3 years, 9 months ago
(2017-03-21 21:36:49 UTC)
#14
CQ is committing da patch. Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490135216357300, "parent_rev": "f310998eccc30373a3ca5ca97e7e72dd59770dc2", "commit_rev": "6bbec23f5e28b88957219401dc946019c1b8c83d"}
3 years, 9 months ago
(2017-03-21 23:14:23 UTC)
#18
CQ is committing da patch.
Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490135216357300,
"parent_rev": "f310998eccc30373a3ca5ca97e7e72dd59770dc2", "commit_rev":
"6bbec23f5e28b88957219401dc946019c1b8c83d"}
commit-bot: I haz the power
Description was changed from ========== [DevTools] Remove dependency from TargetManager to ResourceTreeModel This is aimed ...
3 years, 9 months ago
(2017-03-21 23:16:15 UTC)
#19
Message was sent while issue was closed.
Description was changed from
==========
[DevTools] Remove dependency from TargetManager to ResourceTreeModel
This is aimed to better support targets without frames. For example,
TimelinePanel could now record trace in any target supporting tracing,
and only do so on Ctrl+R for targets with frames.
BUG=none
==========
to
==========
[DevTools] Remove dependency from TargetManager to ResourceTreeModel
This is aimed to better support targets without frames. For example,
TimelinePanel could now record trace in any target supporting tracing,
and only do so on Ctrl+R for targets with frames.
BUG=none
Review-Url: https://codereview.chromium.org/2758963002
Cr-Commit-Position: refs/heads/master@{#458599}
Committed:
https://chromium.googlesource.com/chromium/src/+/6bbec23f5e28b88957219401dc94...
==========
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/6bbec23f5e28b88957219401dc946019c1b8c83d
3 years, 9 months ago
(2017-03-21 23:16:16 UTC)
#20
Issue 2758963002: [DevTools] Remove dependency from TargetManager to ResourceTreeModel
(Closed)
Created 3 years, 9 months ago by dgozman
Modified 3 years, 9 months ago
Reviewers: lushnikov
Base URL:
Comments: 4