third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js - Issue 2758963002: [DevTools] Remove dependency from TargetManager to ResourceTreeModel

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

Issue 2758963002: [DevTools] Remove dependency from TargetManager to ResourceTreeModel (Closed)

Patch Set: review comments addressed Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/network/NetworkLogView.js ('k') | third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

diff --git a/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js b/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

index 9c2493b477809ad6e59af091fcfced16c270f989..afb48cf9472e73cbd165181bfe7a72fdb3396c9d 100644

--- a/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

+++ b/third_party/WebKit/Source/devtools/front_end/network/NetworkOverview.js

@@ -48,9 +48,9 @@ Network.NetworkOverview = class extends PerfUI.TimelineOverviewBase {

* @param {!Common.Event} event

_loadEventFired(event) {

- var data = /** @type {number} */ (event.data);

- if (data)

- this._loadEvents.push(data * 1000);

+ var time = /** @type {number} */ (event.data.loadTime);

+ if (time)

+ this._loadEvents.push(time * 1000);

this.scheduleUpdate();

}