Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Unified Diff: third_party/WebKit/Source/devtools/front_end/audits/AuditController.js

Issue 2758963002: [DevTools] Remove dependency from TargetManager to ResourceTreeModel (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/devtools/front_end/audits/AuditController.js
diff --git a/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js b/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js
index a349ab53f4725a362d70113918d5de9ce66a60d8..ca17a15c8a4b6043fb241641581e2db949280d02 100644
--- a/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js
+++ b/third_party/WebKit/Source/devtools/front_end/audits/AuditController.js
@@ -38,7 +38,8 @@ Audits.AuditController = class {
*/
constructor(auditsPanel) {
this._auditsPanel = auditsPanel;
- SDK.targetManager.addEventListener(SDK.TargetManager.Events.Load, this._didMainResourceLoad, this);
+ SDK.targetManager.addModelListener(
+ SDK.ResourceTreeModel, SDK.ResourceTreeModel.Events.Load, this._didMainResourceLoad, this);
SDK.targetManager.addModelListener(
SDK.NetworkManager, SDK.NetworkManager.Events.RequestFinished, this._didLoadResource, this);
}
@@ -141,7 +142,7 @@ Audits.AuditController = class {
*/
_reloadResources(callback) {
this._pageReloadCallback = callback;
- SDK.targetManager.reloadPage();
+ SDK.ResourceTreeModel.reloadAllPages();
}
_didLoadResource() {
@@ -149,7 +150,12 @@ Audits.AuditController = class {
this._pageReloadCallback();
}
- _didMainResourceLoad() {
+ /**
+ * @param {!Common.Event} event
+ */
+ _didMainResourceLoad(event) {
+ if (event.data.resourceTreeModel.target() !== SDK.targetManager.mainTarget())
+ return;
if (this._pageReloadCallback) {
var callback = this._pageReloadCallback;
delete this._pageReloadCallback;
« no previous file with comments | « no previous file | third_party/WebKit/Source/devtools/front_end/extensions/ExtensionServer.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698