Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js

Issue 2758963002: [DevTools] Remove dependency from TargetManager to ResourceTreeModel (Closed)
Patch Set: review comments addressed Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js
diff --git a/third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js b/third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js
index 2ca5bcfffc4ecf7077532faf7bcdbc85069ca66d..5228f944d693bd129af97767bc02cfc1a448535b 100644
--- a/third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js
+++ b/third_party/WebKit/Source/devtools/front_end/network_log/NetworkLog.js
@@ -56,8 +56,7 @@ NetworkLog.NetworkLog = class {
if (resourceTreeModel) {
eventListeners.push(resourceTreeModel.addEventListener(
SDK.ResourceTreeModel.Events.MainFrameNavigated, this._onMainFrameNavigated, this));
- eventListeners.push(resourceTreeModel.addEventListener(
- SDK.ResourceTreeModel.Events.Load, this._onLoad.bind(this, resourceTreeModel)));
+ eventListeners.push(resourceTreeModel.addEventListener(SDK.ResourceTreeModel.Events.Load, this._onLoad, this));
eventListeners.push(resourceTreeModel.addEventListener(
SDK.ResourceTreeModel.Events.DOMContentLoaded, this._onDOMContentLoaded.bind(this, resourceTreeModel)));
}
@@ -292,13 +291,12 @@ NetworkLog.NetworkLog = class {
}
/**
- * @param {!SDK.ResourceTreeModel} resourceTreeModel
* @param {!Common.Event} event
*/
- _onLoad(resourceTreeModel, event) {
- var pageLoad = this._currentPageLoad.get(resourceTreeModel.target());
+ _onLoad(event) {
+ var pageLoad = this._currentPageLoad.get(event.data.resourceTreeModel.target());
if (pageLoad)
- pageLoad.loadTime = /** @type {number} */ (event.data);
+ pageLoad.loadTime = /** @type {number} */ (event.data.loadTime);
}
/**

Powered by Google App Engine
This is Rietveld 408576698