Change SigninClient::CreateGaiaAuthFetcher return type to unique_ptr

Change SigninClient::CreateGaiaAuthFetcher return type to unique_ptr

CreateGaiaAuthFetcher interface expects the caller to take ownership of the
returned pointer. This CL makes this fact obvious and self-documented by
changing return type to unique_ptr<GaiaAuthFetcher>.

BUG=702574
Review-Url: https://codereview.chromium.org/2757873002
Cr-Commit-Position: refs/heads/master@{#457793}
Committed: https://chromium.googlesource.com/chromium/src/+/553f3552059e1b43cf8ba4d4ef6badfd6db971a6

[bsazonov, 2017-03-17 12:38:01]

The CQ bit was checked by bsazonov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 12:38:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 13:30:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 13:30:08]

Dry run: This issue passed the CQ dry run.

[bsazonov, 2017-03-17 13:59:56]

bsazonov@chromium.org changed reviewers:
+ msarda@chromium.org

[bsazonov, 2017-03-17 13:59:57]

Mihai, please take a look.

[msarda, 2017-03-17 15:55:56]

lgtm

[bsazonov, 2017-03-17 16:22:28]

The CQ bit was checked by bsazonov@chromium.org

[commit-bot: I haz the power, 2017-03-17 16:22:53]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 16:34:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489767748785680, "parent_rev":
"f26905d38e61b7ec3ea082814e3ef497f0450aaf", "commit_rev":
"553f3552059e1b43cf8ba4d4ef6badfd6db971a6"}

[commit-bot: I haz the power, 2017-03-17 16:34:56]

Description was changed from

==========
Change SigninClient::CreateGaiaAuthFetcher return type to unique_ptr

CreateGaiaAuthFetcher interface expects the caller to take ownership of the
returned pointer. This CL makes this fact obvious and self-documented by
changing return type to unique_ptr<GaiaAuthFetcher>.

BUG=702574
==========

to

==========
Change SigninClient::CreateGaiaAuthFetcher return type to unique_ptr

CreateGaiaAuthFetcher interface expects the caller to take ownership of the
returned pointer. This CL makes this fact obvious and self-documented by
changing return type to unique_ptr<GaiaAuthFetcher>.

BUG=702574

Review-Url: https://codereview.chromium.org/2757873002
Cr-Commit-Position: refs/heads/master@{#457793}
Committed:
https://chromium.googlesource.com/chromium/src/+/553f3552059e1b43cf8ba4d4ef6b...
==========

[commit-bot: I haz the power, 2017-03-17 16:34:58]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/553f3552059e1b43cf8ba4d4ef6b...