Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(819)

Unified Diff: components/signin/core/browser/signin_client.h

Issue 2757873002: Change SigninClient::CreateGaiaAuthFetcher return type to unique_ptr (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/signin_client.h
diff --git a/components/signin/core/browser/signin_client.h b/components/signin/core/browser/signin_client.h
index a4910c154dff2e331fe1d7204334d5a43363ab4b..deefb38de9d42aa5854976ddf92c467b1f13fa60 100644
--- a/components/signin/core/browser/signin_client.h
+++ b/components/signin/core/browser/signin_client.h
@@ -5,6 +5,8 @@
#ifndef COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_
#define COMPONENTS_SIGNIN_CORE_BROWSER_SIGNIN_CLIENT_H_
+#include <memory>
+
#include "base/callback.h"
#include "base/callback_list.h"
#include "base/time/time.h"
@@ -116,9 +118,8 @@ class SigninClient : public KeyedService {
// Execute |callback| if and when there is a network connection.
virtual void DelayNetworkCall(const base::Closure& callback) = 0;
- // Creates and returns a new platform-specific GaiaAuthFetcher. It is the
- // responsability of the caller to delete the returned object.
- virtual GaiaAuthFetcher* CreateGaiaAuthFetcher(
+ // Creates a new platform-specific GaiaAuthFetcher.
+ virtual std::unique_ptr<GaiaAuthFetcher> CreateGaiaAuthFetcher(
GaiaAuthConsumer* consumer,
const std::string& source,
net::URLRequestContextGetter* getter) = 0;
« no previous file with comments | « components/signin/core/browser/gaia_cookie_manager_service.cc ('k') | components/signin/core/browser/test_signin_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698