Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Side by Side Diff: ios/chrome/browser/signin/signin_client_impl.h

Issue 2757873002: Change SigninClient::CreateGaiaAuthFetcher return type to unique_ptr (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « google_apis/gaia/ubertoken_fetcher.cc ('k') | ios/chrome/browser/signin/signin_client_impl.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_CHROME_BROWSER_SIGNIN_SIGNIN_CLIENT_IMPL_H_ 5 #ifndef IOS_CHROME_BROWSER_SIGNIN_SIGNIN_CLIENT_IMPL_H_
6 #define IOS_CHROME_BROWSER_SIGNIN_SIGNIN_CLIENT_IMPL_H_ 6 #define IOS_CHROME_BROWSER_SIGNIN_SIGNIN_CLIENT_IMPL_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 net::URLRequestContextGetter* GetURLRequestContext() override; 47 net::URLRequestContextGetter* GetURLRequestContext() override;
48 bool ShouldMergeSigninCredentialsIntoCookieJar() override; 48 bool ShouldMergeSigninCredentialsIntoCookieJar() override;
49 bool IsFirstRun() const override; 49 bool IsFirstRun() const override;
50 base::Time GetInstallDate() override; 50 base::Time GetInstallDate() override;
51 bool AreSigninCookiesAllowed() override; 51 bool AreSigninCookiesAllowed() override;
52 void AddContentSettingsObserver( 52 void AddContentSettingsObserver(
53 content_settings::Observer* observer) override; 53 content_settings::Observer* observer) override;
54 void RemoveContentSettingsObserver( 54 void RemoveContentSettingsObserver(
55 content_settings::Observer* observer) override; 55 content_settings::Observer* observer) override;
56 void DelayNetworkCall(const base::Closure& callback) override; 56 void DelayNetworkCall(const base::Closure& callback) override;
57 GaiaAuthFetcher* CreateGaiaAuthFetcher( 57 std::unique_ptr<GaiaAuthFetcher> CreateGaiaAuthFetcher(
58 GaiaAuthConsumer* consumer, 58 GaiaAuthConsumer* consumer,
59 const std::string& source, 59 const std::string& source,
60 net::URLRequestContextGetter* getter) override; 60 net::URLRequestContextGetter* getter) override;
61 61
62 // KeyedService implementation. 62 // KeyedService implementation.
63 void Shutdown() override; 63 void Shutdown() override;
64 64
65 // Returns a string describing the chrome version environment. Version format: 65 // Returns a string describing the chrome version environment. Version format:
66 // <Build Info> <OS> <Version number> (<Last change>)<channel or "-devel"> 66 // <Build Info> <OS> <Version number> (<Last change>)<channel or "-devel">
67 // If version information is unavailable, returns "invalid." 67 // If version information is unavailable, returns "invalid."
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
101 SigninErrorController* signin_error_controller_; 101 SigninErrorController* signin_error_controller_;
102 std::list<base::Closure> delayed_callbacks_; 102 std::list<base::Closure> delayed_callbacks_;
103 103
104 std::unique_ptr<gaia::GaiaOAuthClient> oauth_client_; 104 std::unique_ptr<gaia::GaiaOAuthClient> oauth_client_;
105 std::unique_ptr<OAuth2TokenService::Request> oauth_request_; 105 std::unique_ptr<OAuth2TokenService::Request> oauth_request_;
106 106
107 DISALLOW_COPY_AND_ASSIGN(SigninClientImpl); 107 DISALLOW_COPY_AND_ASSIGN(SigninClientImpl);
108 }; 108 };
109 109
110 #endif // IOS_CHROME_BROWSER_SIGNIN_SIGNIN_CLIENT_IMPL_H_ 110 #endif // IOS_CHROME_BROWSER_SIGNIN_SIGNIN_CLIENT_IMPL_H_
OLDNEW
« no previous file with comments | « google_apis/gaia/ubertoken_fetcher.cc ('k') | ios/chrome/browser/signin/signin_client_impl.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698