Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: components/signin/core/browser/gaia_cookie_manager_service.cc

Issue 2757873002: Change SigninClient::CreateGaiaAuthFetcher return type to unique_ptr (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/signin/core/browser/gaia_cookie_manager_service.cc
diff --git a/components/signin/core/browser/gaia_cookie_manager_service.cc b/components/signin/core/browser/gaia_cookie_manager_service.cc
index 3076b958aee4a44f6939d1543c7a9d6462276e9a..a3aa65fe8ee2c95e6fe3d8ab3455e108b0d0a89c 100644
--- a/components/signin/core/browser/gaia_cookie_manager_service.cc
+++ b/components/signin/core/browser/gaia_cookie_manager_service.cc
@@ -137,10 +137,8 @@ void GaiaCookieManagerService::ExternalCcResultFetcher::Start() {
CleanupTransientState();
results_.clear();
- helper_->gaia_auth_fetcher_.reset(
- helper_->signin_client_->CreateGaiaAuthFetcher(
- this, helper_->GetDefaultSourceForRequest(),
- helper_->request_context()));
+ helper_->gaia_auth_fetcher_ = helper_->signin_client_->CreateGaiaAuthFetcher(
+ this, helper_->GetDefaultSourceForRequest(), helper_->request_context());
helper_->gaia_auth_fetcher_->StartGetCheckConnectionInfo();
// Some fetches may timeout. Start a timer to decide when the result fetcher
@@ -758,9 +756,9 @@ void GaiaCookieManagerService::StartFetchingUbertoken() {
void GaiaCookieManagerService::StartFetchingMergeSession() {
DCHECK(!uber_token_.empty());
- gaia_auth_fetcher_.reset(signin_client_->CreateGaiaAuthFetcher(
+ gaia_auth_fetcher_ = signin_client_->CreateGaiaAuthFetcher(
this, GetSourceForRequest(requests_.front()),
- signin_client_->GetURLRequestContext()));
+ signin_client_->GetURLRequestContext());
gaia_auth_fetcher_->StartMergeSession(uber_token_,
external_cc_result_fetcher_.GetExternalCcResult());
@@ -769,18 +767,18 @@ void GaiaCookieManagerService::StartFetchingMergeSession() {
void GaiaCookieManagerService::StartFetchingLogOut() {
DCHECK(requests_.front().request_type() == GaiaCookieRequestType::LOG_OUT);
VLOG(1) << "GaiaCookieManagerService::StartFetchingLogOut";
- gaia_auth_fetcher_.reset(signin_client_->CreateGaiaAuthFetcher(
+ gaia_auth_fetcher_ = signin_client_->CreateGaiaAuthFetcher(
this, GetSourceForRequest(requests_.front()),
- signin_client_->GetURLRequestContext()));
+ signin_client_->GetURLRequestContext());
gaia_auth_fetcher_->StartLogOut();
}
void GaiaCookieManagerService::StartFetchingListAccounts() {
VLOG(1) << "GaiaCookieManagerService::ListAccounts";
- gaia_auth_fetcher_.reset(signin_client_->CreateGaiaAuthFetcher(
+ gaia_auth_fetcher_ = signin_client_->CreateGaiaAuthFetcher(
this, GetSourceForRequest(requests_.front()),
- signin_client_->GetURLRequestContext()));
+ signin_client_->GetURLRequestContext());
gaia_auth_fetcher_->StartListAccounts();
}
« no previous file with comments | « components/signin/core/browser/child_account_info_fetcher_impl.cc ('k') | components/signin/core/browser/signin_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698