Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(424)

Issue 2756463004: [Cleanup] Remove the ability to disable Crash Reporting from the command line. (Closed)

Created:
3 years, 9 months ago by Ilya Sherman
Modified:
3 years, 9 months ago
CC:
chromium-reviews, sadrul, asvitkine+watch_chromium.org, agrieve+watch_chromium.org, kalyank, android-webview-reviews_chromium.org, gayane+watch_chromium.org, inferno
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Cleanup] Remove the ability to disable Crash Reporting from the command line. This was previously used by the ClusterFuzz project, but is no longer needed, as that project simply does not set the user consent bit for upload crash reports. BUG=none TEST=none R=jchinlee@chromium.org, mariakhomenko@chromium.org TBR=tobiasjs@chromium.org Review-Url: https://codereview.chromium.org/2756463004 Cr-Commit-Position: refs/heads/master@{#457867} Committed: https://chromium.googlesource.com/chromium/src/+/32133318763d82abf62bea930c40996edbee0671

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -163 lines) Patch
M android_webview/java/src/org/chromium/android_webview/crash/AwMinidumpUploaderDelegate.java View 1 chunk +0 lines, -4 lines 0 comments Download
M android_webview/javatests/src/org/chromium/android_webview/test/crash/MinidumpUploaderTest.java View 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeSwitches.java View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java View 3 chunks +11 lines, -19 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java View 3 chunks +0 lines, -33 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java View 1 chunk +0 lines, -1 line 0 comments Download
M components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/MinidumpUploadCallable.java View 2 chunks +1 line, -9 lines 0 comments Download
M components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java View 1 chunk +0 lines, -12 lines 0 comments Download
M components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/CrashTestCase.java View 2 chunks +0 lines, -6 lines 0 comments Download
M components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java View 11 chunks +0 lines, -58 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 21 (11 generated)
Ilya Sherman
3 years, 9 months ago (2017-03-17 00:18:10 UTC) #1
Maria
lgtm
3 years, 9 months ago (2017-03-17 04:35:23 UTC) #6
jchinlee
lgtm Abhishek --- just FYI, we should take out --disable-dump-upload. According to Gayane, the --disable-fre ...
3 years, 9 months ago (2017-03-17 18:35:09 UTC) #7
Ilya Sherman
Thanks! Submitting. Please let me know, and feel free to revert this CL, if anything ...
3 years, 9 months ago (2017-03-17 19:37:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756463004/1
3 years, 9 months ago (2017-03-17 19:38:17 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/388398)
3 years, 9 months ago (2017-03-17 19:47:07 UTC) #12
Ilya Sherman
+TBR Toby for trivial code removal within android_webview/
3 years, 9 months ago (2017-03-17 19:53:13 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756463004/1
3 years, 9 months ago (2017-03-17 19:53:54 UTC) #17
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/32133318763d82abf62bea930c40996edbee0671
3 years, 9 months ago (2017-03-17 20:01:36 UTC) #20
Tobias Sargeant
3 years, 9 months ago (2017-03-17 20:02:14 UTC) #21
Message was sent while issue was closed.
On 2017/03/17 19:53:13, Ilya Sherman wrote:
> +TBR Toby for trivial code removal within android_webview/

rs-LGTM

Powered by Google App Engine
This is Rietveld 408576698