[Cleanup] Remove the ability to disable Crash Reporting from the command line.

components/minidump_uploader/android/javatests/src/org/chromium/components/minidump_uploader/MinidumpUploadCallableTest.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.components.minidump_uploader;
 
 import android.support.test.filters.SmallTest;
 
 import org.chromium.base.annotations.SuppressFBWarnings;
 import org.chromium.base.test.util.Feature;
@@ skipping 148 matching lines @@
 
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testCallWhenCurrentlyPermitted() throws Exception {
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = true;
                         mIsPermitted = true;
                         mIsUserPermitted = true;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = true;
                         mIsEnabledForTests = false;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(MinidumpUploadCallable.UPLOAD_SUCCESS,
                 minidumpUploadCallable.call().intValue());
         assertTrue(mExpectedFileAfterUpload.exists());
         assertValidUploadLogEntry();
     }
 
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testCallNotPermittedByUser() throws Exception {
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = true;
                         mIsPermitted = false;
                         mIsUserPermitted = false;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = true;
                         mIsEnabledForTests = false;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new FailHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(MinidumpUploadCallable.UPLOAD_USER_DISABLED,
                 minidumpUploadCallable.call().intValue());
 
         File expectedSkippedFileAfterUpload =
                 new File(mCrashDir, mTestUpload.getName().replace(".dmp", ".skipped"));
         assertTrue(expectedSkippedFileAfterUpload.exists());
         assertFalse(mExpectedFileAfterUpload.exists());
     }
 
     @SmallTest
     @Feature({"Android-AppBase"})
-    public void testCallNotPermittedByCommandLine() throws Exception {
-        CrashReportingPermissionManager testPermManager =
-                new MockCrashReportingPermissionManager() {
-                    {
-                        mIsInSample = true;
-                        mIsPermitted = true;
-                        mIsUserPermitted = true;
-                        mIsCommandLineDisabled = true;
-                        mIsNetworkAvailable = true;
-                        mIsEnabledForTests = false;
-                    }
-                };
-
-        HttpURLConnectionFactory httpURLConnectionFactory = new FailHttpURLConnectionFactory();
-
-        MinidumpUploadCallable minidumpUploadCallable =
-                new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
-        assertEquals(MinidumpUploadCallable.UPLOAD_COMMANDLINE_DISABLED,
-                minidumpUploadCallable.call().intValue());
-        assertFalse(mExpectedFileAfterUpload.exists());
-    }
-
-    @SmallTest
-    @Feature({"Android-AppBase"})
     public void testCallPermittedButNotInSample() throws Exception {
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = false;
                         mIsPermitted = true;
                         mIsUserPermitted = true;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = true;
                         mIsEnabledForTests = false;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(MinidumpUploadCallable.UPLOAD_DISABLED_BY_SAMPLING,
                 minidumpUploadCallable.call().intValue());
 
         File expectedSkippedFileAfterUpload =
                 new File(mCrashDir, mTestUpload.getName().replace(".dmp", ".skipped"));
         assertTrue(expectedSkippedFileAfterUpload.exists());
         assertFalse(mExpectedFileAfterUpload.exists());
     }
 
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testCallPermittedButNotUnderCurrentCircumstances() throws Exception {
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = true;
                         mIsPermitted = true;
                         mIsUserPermitted = true;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = false;
                         mIsEnabledForTests = false;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new FailHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(MinidumpUploadCallable.UPLOAD_FAILURE,
                 minidumpUploadCallable.call().intValue());
         assertFalse(mExpectedFileAfterUpload.exists());
     }
 
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testCrashUploadEnabledForTestsDespiteConstraints() throws Exception {
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = true;
                         mIsPermitted = false;
                         mIsUserPermitted = false;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = false;
                         mIsEnabledForTests = true;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(MinidumpUploadCallable.UPLOAD_SUCCESS,
                 minidumpUploadCallable.call().intValue());
         assertTrue(mExpectedFileAfterUpload.exists());
         assertValidUploadLogEntry();
     }
 
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testCallWhenCurrentlyPermitted_ForcedUpload() throws Exception {
         setForcedUpload();
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = true;
                         mIsPermitted = true;
                         mIsUserPermitted = true;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = true;
                         mIsEnabledForTests = false;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(
                 MinidumpUploadCallable.UPLOAD_SUCCESS, minidumpUploadCallable.call().intValue());
         assertTrue(mExpectedFileAfterUpload.exists());
         assertValidUploadLogEntry();
     }
 
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testCallNotPermittedByUser_ForcedUpload() throws Exception {
         setForcedUpload();
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = true;
                         mIsPermitted = false;
                         mIsUserPermitted = false;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = true;
                         mIsEnabledForTests = false;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(
                 MinidumpUploadCallable.UPLOAD_SUCCESS, minidumpUploadCallable.call().intValue());
 
         File expectedSkippedFileAfterUpload =
                 new File(mCrashDir, mTestUpload.getName().replace(".forced", ".skipped"));
         assertFalse(expectedSkippedFileAfterUpload.exists());
         assertTrue(mExpectedFileAfterUpload.exists());
     }
 
     @SmallTest
     @Feature({"Android-AppBase"})
-    public void testCallNotPermittedByCommandLine_ForcedUpload() throws Exception {
-        setForcedUpload();
-        CrashReportingPermissionManager testPermManager =
-                new MockCrashReportingPermissionManager() {
-                    {
-                        mIsInSample = true;
-                        mIsPermitted = true;
-                        mIsUserPermitted = true;
-                        mIsCommandLineDisabled = true;
-                        mIsNetworkAvailable = true;
-                        mIsEnabledForTests = false;
-                    }
-                };
-
-        HttpURLConnectionFactory httpURLConnectionFactory = new FailHttpURLConnectionFactory();
-
-        MinidumpUploadCallable minidumpUploadCallable =
-                new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
-        assertEquals(MinidumpUploadCallable.UPLOAD_COMMANDLINE_DISABLED,
-                minidumpUploadCallable.call().intValue());
-        assertFalse(mExpectedFileAfterUpload.exists());
-    }
-
-    @SmallTest
-    @Feature({"Android-AppBase"})
     public void testCallPermittedButNotInSample_ForcedUpload() throws Exception {
         setForcedUpload();
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = false;
                         mIsPermitted = true;
                         mIsUserPermitted = true;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = true;
                         mIsEnabledForTests = false;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(
                 MinidumpUploadCallable.UPLOAD_SUCCESS, minidumpUploadCallable.call().intValue());
 
         File expectedSkippedFileAfterUpload =
                 new File(mCrashDir, mTestUpload.getName().replace(".forced", ".skipped"));
         assertFalse(expectedSkippedFileAfterUpload.exists());
         assertTrue(mExpectedFileAfterUpload.exists());
     }
 
     @SmallTest
     @Feature({"Android-AppBase"})
     public void testCallPermittedButNotUnderCurrentCircumstances_ForcedUpload() throws Exception {
         setForcedUpload();
         CrashReportingPermissionManager testPermManager =
                 new MockCrashReportingPermissionManager() {
                     {
                         mIsInSample = true;
                         mIsPermitted = true;
                         mIsUserPermitted = true;
-                        mIsCommandLineDisabled = false;
                         mIsNetworkAvailable = false;
                         mIsEnabledForTests = false;
                     }
                 };
 
         HttpURLConnectionFactory httpURLConnectionFactory = new TestHttpURLConnectionFactory();
 
         MinidumpUploadCallable minidumpUploadCallable =
                 new MockMinidumpUploadCallable(httpURLConnectionFactory, testPermManager);
         assertEquals(
@@ skipping 35 matching lines @@
 
         // Sanity check on the time stamp (within an hour).
         // Chances are the write and the check should have less than 1 second in between.
         assertTrue(time <= now);
         assertTrue(time > now - 60 * 60);
 
         String id = lastEntry.substring(seperator + 1, lastEntry.length());
         assertEquals(id, CRASH_ID);
     }
 }