Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java

Issue 2756463004: [Cleanup] Remove the ability to disable Crash Reporting from the command line. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
diff --git a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
index 5d05c12c2472ca295f655679d1e9f34767664725..47f34f8e3f8aa3f1096fe7312128342d14652fc3 100644
--- a/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
+++ b/components/minidump_uploader/android/java/src/org/chromium/components/minidump_uploader/util/CrashReportingPermissionManager.java
@@ -33,18 +33,6 @@ public interface CrashReportingPermissionManager {
*/
public boolean isMetricsUploadPermitted();
- // TODO(isherman): Remove this function. It was previously used to enable a specific type of
- // test, but it should not be necessary anymore. (Note: There are currently some clients that do
- // partly depend on it, so it is not necessarily safe to remove without contacting those
- // clients.)
- /**
- * Checks whether uploading of crash dumps is permitted, based on the corresponding command line
- * flag only.
- *
- * @return whether uploading of crash dumps is enabled or disabled by a command line flag.
- */
- public boolean isCrashUploadDisabledByCommandLine();
-
/**
* Checks whether uploading of usage metrics and crash dumps is currently permitted, based on
* user consent only.

Powered by Google App Engine
This is Rietveld 408576698