chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java - Issue 2756463004: [Cleanup] Remove the ability to disable Crash Reporting from the command line.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java

Issue 2756463004: [Cleanup] Remove the ability to disable Crash Reporting from the command line. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/DeferredStartupHandler.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/crash/MinidumpUploadService.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java

index 6958ae1804cc9dafb5b3b6098074784938656d87..55e742f74be7efd50883c23457e530896fdbd1e9 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/crash/ChromeMinidumpUploaderDelegate.java

@@ -23,8 +23,6 @@ import java.io.File;

public class ChromeMinidumpUploaderDelegate implements MinidumpUploaderDelegate {

// PersistableBundle keys:

static final String IS_CLIENT_IN_METRICS_SAMPLE = "isClientInMetricsSample";

- static final String IS_CRASH_UPLOAD_DISABLED_BY_COMMAND_LINE =

- "isCrashUploadDisabledByCommandLine";

static final String IS_UPLOAD_ENABLED_FOR_TESTS = "isUploadEnabledForTests";

/**

@@ -82,11 +80,6 @@ public class ChromeMinidumpUploaderDelegate implements MinidumpUploaderDelegate

}

@Override

- public boolean isCrashUploadDisabledByCommandLine() {

- return mPermissions.getBoolean(IS_CRASH_UPLOAD_DISABLED_BY_COMMAND_LINE, false);

- }

- @Override

public boolean isMetricsUploadPermitted() {

// This method is already represented by isClientInMetricsSample() and

// isNetworkAvailableForCrashUploads(), so it's fine to return a dummy value.