Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 2756383002: Change Frame to store a Page instead of a FrameHost. (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, joelhockey
CC:
blink-reviews, blink-reviews-frames_chromium.org, chromium-reviews, dcheng, mlamouri+watch-blink_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change Frame to store a Page instead of a FrameHost. Since all methods have already been removed off FrameHost, change Frame to store a Page and remove the indirection caused from going through the FrameHost. This is pre-work to remove FrameHost. LocalFrame and RemoteFrame will be updated similarly in a follow-up patch. BUG=688614

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -22 lines) Patch
M third_party/WebKit/Source/core/frame/Frame.h View 2 chunks +7 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/frame/Frame.cpp View 4 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 3 chunks +7 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 2 chunks +5 lines, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
sashab
3 years, 9 months ago (2017-03-20 04:58:03 UTC) #2
haraken
LGTM
3 years, 9 months ago (2017-03-20 05:37:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2756383002/1
3 years, 9 months ago (2017-03-20 05:45:10 UTC) #5
joelhockey
lgtm
3 years, 9 months ago (2017-03-20 06:35:48 UTC) #7
commit-bot: I haz the power
3 years, 9 months ago (2017-03-20 07:36:08 UTC) #10
Prior attempt to commit was detected, but we were not able to check whether the
issue was successfully committed. Please check Git history manually and re-check
CQ or close this issue as needed.

Powered by Google App Engine
This is Rietveld 408576698