Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(95)

Side by Side Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2756383002: Change Frame to store a Page instead of a FrameHost. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Frame.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org> 2 * Copyright (C) 1998, 1999 Torben Weis <weis@kde.org>
3 * 1999-2001 Lars Knoll <knoll@kde.org> 3 * 1999-2001 Lars Knoll <knoll@kde.org>
4 * 1999-2001 Antti Koivisto <koivisto@kde.org> 4 * 1999-2001 Antti Koivisto <koivisto@kde.org>
5 * 2000-2001 Simon Hausmann <hausmann@kde.org> 5 * 2000-2001 Simon Hausmann <hausmann@kde.org>
6 * 2000-2001 Dirk Mueller <mueller@kde.org> 6 * 2000-2001 Dirk Mueller <mueller@kde.org>
7 * 2000 Stefan Schimanski <1Stein@gmx.de> 7 * 2000 Stefan Schimanski <1Stein@gmx.de>
8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 8 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
9 * reserved. 9 * reserved.
10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies) 10 * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
(...skipping 71 matching lines...) Expand 10 before | Expand all | Expand 10 after
82 // to be started on a timer. Use the method above in such cases. 82 // to be started on a timer. Use the method above in such cases.
83 virtual void navigate(const FrameLoadRequest&) = 0; 83 virtual void navigate(const FrameLoadRequest&) = 0;
84 virtual void reload(FrameLoadType, ClientRedirectPolicy) = 0; 84 virtual void reload(FrameLoadType, ClientRedirectPolicy) = 0;
85 85
86 virtual void detach(FrameDetachType); 86 virtual void detach(FrameDetachType);
87 void disconnectOwnerElement(); 87 void disconnectOwnerElement();
88 virtual bool shouldClose() = 0; 88 virtual bool shouldClose() = 0;
89 89
90 FrameClient* client() const; 90 FrameClient* client() const;
91 91
92 // NOTE: Page is moving out of Blink up into the browser process as 92 Page* page() const; // Null when the frame is detached.
93 // part of the site-isolation (out of process iframes) work. 93
94 // FrameHost should be used instead where possible. 94 // Deprecated; use page() instead.
95 Page* page() const; 95 // TODO(sashab): Remove this method.
96 FrameHost* host() const; // Null when the frame is detached. 96 FrameHost* host() const;
97 97
98 bool isMainFrame() const; 98 bool isMainFrame() const;
99 bool isLocalRoot() const; 99 bool isLocalRoot() const;
100 100
101 FrameOwner* owner() const; 101 FrameOwner* owner() const;
102 void setOwner(FrameOwner* owner) { m_owner = owner; } 102 void setOwner(FrameOwner* owner) { m_owner = owner; }
103 HTMLFrameOwnerElement* deprecatedLocalOwner() const; 103 HTMLFrameOwnerElement* deprecatedLocalOwner() const;
104 104
105 DOMWindow* domWindow() const { return m_domWindow; } 105 DOMWindow* domWindow() const { return m_domWindow; }
106 106
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 void setDocumentHasReceivedUserGesture(); 149 void setDocumentHasReceivedUserGesture();
150 bool hasReceivedUserGesture() const { return m_hasReceivedUserGesture; } 150 bool hasReceivedUserGesture() const { return m_hasReceivedUserGesture; }
151 151
152 bool isDetaching() const { return m_isDetaching; } 152 bool isDetaching() const { return m_isDetaching; }
153 153
154 // Tests whether the feature-policy controlled feature is enabled by policy in 154 // Tests whether the feature-policy controlled feature is enabled by policy in
155 // the given frame. 155 // the given frame.
156 bool isFeatureEnabled(WebFeaturePolicyFeature) const; 156 bool isFeatureEnabled(WebFeaturePolicyFeature) const;
157 157
158 protected: 158 protected:
159 Frame(FrameClient*, FrameHost*, FrameOwner*, WindowProxyManager*); 159 Frame(FrameClient*, Page*, FrameOwner*, WindowProxyManager*);
160 160
161 mutable FrameTree m_treeNode; 161 mutable FrameTree m_treeNode;
162 162
163 Member<FrameHost> m_host; 163 Member<Page> m_page;
164 Member<FrameOwner> m_owner; 164 Member<FrameOwner> m_owner;
165 Member<DOMWindow> m_domWindow; 165 Member<DOMWindow> m_domWindow;
166 166
167 bool m_hasReceivedUserGesture = false; 167 bool m_hasReceivedUserGesture = false;
168 bool m_isDetaching = false; 168 bool m_isDetaching = false;
169 169
170 private: 170 private:
171 bool canNavigateWithoutFramebusting(const Frame&, String& errorReason); 171 bool canNavigateWithoutFramebusting(const Frame&, String& errorReason);
172 172
173 Member<FrameClient> m_client; 173 Member<FrameClient> m_client;
(...skipping 13 matching lines...) Expand all
187 return m_treeNode; 187 return m_treeNode;
188 } 188 }
189 189
190 // Allow equality comparisons of Frames by reference or pointer, 190 // Allow equality comparisons of Frames by reference or pointer,
191 // interchangeably. 191 // interchangeably.
192 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame) 192 DEFINE_COMPARISON_OPERATORS_WITH_REFERENCES(Frame)
193 193
194 } // namespace blink 194 } // namespace blink
195 195
196 #endif // Frame_h 196 #endif // Frame_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Frame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698