Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Issue 2763513002: Change LocalFrame to take a Page instead of a FrameHost (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
slangley, haraken
CC:
blink-reviews, blink-reviews-frames_chromium.org, blink-reviews-layout_chromium.org, chromium-reviews, krit, eae+blinkwatch, fmalita+watch_chromium.org, fs, gyuyoung2, hongchan, jchaffraix+rendering, kinuko+watch, kouhei+svg_chromium.org, leviw+renderwatch, pdr+svgwatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rwlbuis, Raymond Toy, Stephen Chennney, szager+layoutwatch_chromium.org, Yoav Weiss, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change LocalFrame to take a Page instead of a FrameHost Now that Frame stores a Page, this just updates the LocalFrame constructor to take a Page. This is pre-work to remove FrameHost. BUG=688614 Review-Url: https://codereview.chromium.org/2763513002 Cr-Commit-Position: refs/heads/master@{#458306} Committed: https://chromium.googlesource.com/chromium/src/+/2489d6c5bdbfb5d1ac15afcb30870c30c3b47662

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -22 lines) Patch
M third_party/WebKit/Source/core/frame/LocalFrame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/LocalFrame.cpp View 2 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTestHelper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/loader/FrameFetchContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/graphics/SVGImage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/testing/DummyPageHolder.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/BaseAudioContextTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/InspectorOverlay.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/WebPagePopupImpl.cpp View 1 chunk +1 line, -2 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
sashab
3 years, 9 months ago (2017-03-20 06:06:41 UTC) #2
slangley
lgtm
3 years, 9 months ago (2017-03-20 06:08:27 UTC) #3
sashab
haraken ptal
3 years, 9 months ago (2017-03-20 06:09:21 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-20 07:25:08 UTC) #6
commit-bot: I haz the power
This CL has an open dependency (Issue 2756383002 Patch 1). Please resolve the dependency and ...
3 years, 9 months ago (2017-03-21 01:58:42 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2763513002/1
3 years, 9 months ago (2017-03-21 02:00:04 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 03:59:48 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2489d6c5bdbfb5d1ac15afcb3087...

Powered by Google App Engine
This is Rietveld 408576698