Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Issue 2760813002: Change RemoteFrame to take a Page instead of a FrameHost (Closed)

Created:
3 years, 9 months ago by sashab
Modified:
3 years, 9 months ago
Reviewers:
haraken, slangley, dglazkov
CC:
blink-reviews, blink-reviews-dom_chromium.org, blink-reviews-frames_chromium.org, chromium-reviews, dcheng, dglazkov+blink, eae+blinkwatch, kinuko+watch, mlamouri+watch-blink_chromium.org, rwlbuis, sof
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Change RemoteFrame to take a Page instead of a FrameHost Now that Frame stores a Page, this just updates the RemoteFrame constructor to take a Page. This is pre-work to remove FrameHost. BUG=688614 Review-Url: https://codereview.chromium.org/2760813002 Cr-Commit-Position: refs/heads/master@{#458296} Committed: https://chromium.googlesource.com/chromium/src/+/c0689312b5fd92ae2325bdc4b219a931b0d5d831

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -12 lines) Patch
M third_party/WebKit/Source/core/dom/ElementVisibilityObserverTest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/frame/RemoteFrame.cpp View 1 chunk +4 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/web/WebRemoteFrameImpl.cpp View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (6 generated)
sashab
See dependent patchset for more context. :)
3 years, 9 months ago (2017-03-20 05:07:04 UTC) #2
slangley
lgtm
3 years, 9 months ago (2017-03-20 05:22:53 UTC) #3
sashab
ty stu. haraken ptal
3 years, 9 months ago (2017-03-20 05:24:04 UTC) #5
haraken
LGTM
3 years, 9 months ago (2017-03-20 05:37:38 UTC) #6
dglazkov
lgtm
3 years, 9 months ago (2017-03-20 16:45:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2760813002/1
3 years, 9 months ago (2017-03-21 01:59:06 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 03:44:08 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/c0689312b5fd92ae2325bdc4b219...

Powered by Google App Engine
This is Rietveld 408576698