Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1694)

Unified Diff: third_party/WebKit/Source/core/frame/Frame.h

Issue 2756383002: Change Frame to store a Page instead of a FrameHost. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Frame.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/Frame.h
diff --git a/third_party/WebKit/Source/core/frame/Frame.h b/third_party/WebKit/Source/core/frame/Frame.h
index ee53c6122c22baacf8b8f7455e6bc105ac146791..e84cdabc262b1f79297278ee84405a3bce6262bb 100644
--- a/third_party/WebKit/Source/core/frame/Frame.h
+++ b/third_party/WebKit/Source/core/frame/Frame.h
@@ -89,11 +89,11 @@ class CORE_EXPORT Frame : public GarbageCollectedFinalized<Frame> {
FrameClient* client() const;
- // NOTE: Page is moving out of Blink up into the browser process as
- // part of the site-isolation (out of process iframes) work.
- // FrameHost should be used instead where possible.
- Page* page() const;
- FrameHost* host() const; // Null when the frame is detached.
+ Page* page() const; // Null when the frame is detached.
+
+ // Deprecated; use page() instead.
+ // TODO(sashab): Remove this method.
+ FrameHost* host() const;
bool isMainFrame() const;
bool isLocalRoot() const;
@@ -156,11 +156,11 @@ class CORE_EXPORT Frame : public GarbageCollectedFinalized<Frame> {
bool isFeatureEnabled(WebFeaturePolicyFeature) const;
protected:
- Frame(FrameClient*, FrameHost*, FrameOwner*, WindowProxyManager*);
+ Frame(FrameClient*, Page*, FrameOwner*, WindowProxyManager*);
mutable FrameTree m_treeNode;
- Member<FrameHost> m_host;
+ Member<Page> m_page;
Member<FrameOwner> m_owner;
Member<DOMWindow> m_domWindow;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/frame/Frame.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698