Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2755753003: Ignore pointer capture target while calculating click target (Closed)

Created:
1 year, 2 months ago by Navid Zolghadr
Modified:
1 year, 2 months ago
Reviewers:
dtapuska, mustaq, bokan
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Ignore pointer capture target while calculating click target After https://codereview.chromium.org/2681443003 it turns out we are creating some regressions. So this change keeps the essence of the original change for the purpose of keeping the metric but ignores the target that is calculated from the captured target and use the original click target regardless of the capturing. BUG=701599, 699933 Review-Url: https://codereview.chromium.org/2755753003 Cr-Commit-Position: refs/heads/master@{#458091} Committed: https://chromium.googlesource.com/chromium/src/+/ddb951c0cc2912acd57e4238677b82e6360ac1ad

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -22 lines) Patch
A third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_click_during_capture-manual-expected.txt View 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 chunk +23 lines, -15 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +7 lines, -7 lines 0 comments Download

Messages

Total messages: 25 (13 generated)
Navid Zolghadr
1 year, 2 months ago (2017-03-16 16:43:50 UTC) #3
dtapuska
lgtm
1 year, 2 months ago (2017-03-17 18:40:51 UTC) #7
Navid Zolghadr
1 year, 2 months ago (2017-03-17 18:42:45 UTC) #9
bokan
rs lgtm based on Dave's review
1 year, 2 months ago (2017-03-17 19:03:19 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755753003/1
1 year, 2 months ago (2017-03-17 19:12:54 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/386113)
1 year, 2 months ago (2017-03-17 20:33:59 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755753003/1
1 year, 2 months ago (2017-03-17 20:38:20 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/403124)
1 year, 2 months ago (2017-03-17 20:45:49 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2755753003/1
1 year, 2 months ago (2017-03-20 14:19:09 UTC) #20
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/ddb951c0cc2912acd57e4238677b82e6360ac1ad
1 year, 2 months ago (2017-03-20 16:46:34 UTC) #23
johnme
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2764813004/ by johnme@chromium.org. ...
1 year, 2 months ago (2017-03-21 12:44:09 UTC) #24
Navid Zolghadr
1 year, 2 months ago (2017-03-21 17:15:49 UTC) #25
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2762913003/ by nzolghadr@chromium.org.

The reason for reverting is: Reverting all the changes related to click target
in capturing as they are splitted across multiple commits..

Powered by Google App Engine
This is Rietveld 408576698