Send click event after pointer capturing retarget

Send click event after pointer capturing retarget

When calculating click event target we need to
use the captured target. Moving sending click
event further down in PointerEventManager allows
us to do that.

BUG=689158
Review-Url: https://codereview.chromium.org/2681443003
Cr-Commit-Position: refs/heads/master@{#453604}
Committed: https://chromium.googlesource.com/chromium/src/+/14cea387ce9359e5f9fe3e90c996adf75e092e64

[Navid Zolghadr, 2017-02-06 21:16:01]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-06 21:16:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-06 23:06:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-06 23:06:10]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2017-02-10 20:09:07]

nzolghadr@chromium.org changed reviewers:
+ mustaq@chromium.org

[mustaq, 2017-02-10 21:16:53]

LGTM module a suggestion.

Perhaps add (in the CL description) the wpt test name that will cover this.

https://codereview.chromium.org/2681443003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/input/EventHandler.cpp (right):

https://codereview.chromium.org/2681443003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/input/EventHandler.cpp:1261: bool
sendClickIfNeeded) {
Can the name |sendClickIfNeeded| be more specific here and in PEM? (The name in
MEM is fine.) I was about to suggest inverting the bit and call it
"selectionActiveOnLink" but looks like |isLinkSelection()| itself is a misnomer.
Consider renaming that too?

[Navid Zolghadr, 2017-02-27 20:25:02]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 20:25:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-02-27 20:34:45]

The CQ bit was checked by nzolghadr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-27 20:35:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Navid Zolghadr, 2017-02-27 20:35:22]

nzolghadr@chromium.org changed reviewers:
+ bokan@chromium.org

[bokan, 2017-02-27 22:46:28]

rs lgtm based on Mustaq's review

[commit-bot: I haz the power, 2017-02-27 22:53:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-27 22:53:38]

Dry run: This issue passed the CQ dry run.

[Navid Zolghadr, 2017-02-28 15:16:55]

The CQ bit was checked by nzolghadr@chromium.org

[Navid Zolghadr, 2017-02-28 15:16:56]

The patchset sent to the CQ was uploaded after l-g-t-m from mustaq@chromium.org
Link to the patchset: https://codereview.chromium.org/2681443003/#ps40001
(title: "Rename the function and the parameter names")

[commit-bot: I haz the power, 2017-02-28 15:17:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-28 15:22:35]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488295015805610,
"parent_rev": "ef2a8e07616635ec90e8b30a95fb8a43a7f0ec9a", "commit_rev":
"14cea387ce9359e5f9fe3e90c996adf75e092e64"}

[commit-bot: I haz the power, 2017-02-28 15:23:10]

Description was changed from

==========
Send click event after pointer capturing retarget

When calculating click event target we need to
use the captured target. Moving sending click
event further down in PointerEventManager allows
us to do that.

BUG=689158
==========

to

==========
Send click event after pointer capturing retarget

When calculating click event target we need to
use the captured target. Moving sending click
event further down in PointerEventManager allows
us to do that.

BUG=689158

Review-Url: https://codereview.chromium.org/2681443003
Cr-Commit-Position: refs/heads/master@{#453604}
Committed:
https://chromium.googlesource.com/chromium/src/+/14cea387ce9359e5f9fe3e90c996...
==========

[commit-bot: I haz the power, 2017-02-28 15:23:11]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/14cea387ce9359e5f9fe3e90c996...