Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2762913003: Revert of Ignore pointer capture target while calculating click target (Closed)

Created:
3 years, 9 months ago by Navid Zolghadr
Modified:
3 years, 9 months ago
Reviewers:
dtapuska, mustaq, bokan
CC:
chromium-reviews, blink-reviews, blink-reviews-w3ctests_chromium.org, dtapuska+blinkwatch_chromium.org, Navid Zolghadr
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Ignore pointer capture target while calculating click target (patchset #1 id:1 of https://codereview.chromium.org/2755753003/ ) Reason for revert: Reverting all the changes related to the click target in capturing as they are splitted across multiple commits. Original issue's description: > Ignore pointer capture target while calculating click target > > After https://codereview.chromium.org/2681443003 > it turns out we are creating some regressions. > So this change keeps the essence of the original > change for the purpose of keeping the metric but > ignores the target that is calculated from the > captured target and use the original click target > regardless of the capturing. > > BUG=701599, 699933 > > Review-Url: https://codereview.chromium.org/2755753003 > Cr-Commit-Position: refs/heads/master@{#458091} > Committed: https://chromium.googlesource.com/chromium/src/+/ddb951c0cc2912acd57e4238677b82e6360ac1ad TBR=dtapuska@chromium.org,mustaq@chromium.org,bokan@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=701599, 699933 Review-Url: https://codereview.chromium.org/2762913003 Cr-Commit-Position: refs/heads/master@{#458506} Committed: https://chromium.googlesource.com/chromium/src/+/1b708802860053bad35e8eaad2508f87701ec18b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -38 lines) Patch
D third_party/WebKit/LayoutTests/external/wpt/pointerevents/pointerevent_click_during_capture-manual-expected.txt View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/WebKit/Source/core/input/MouseEventManager.cpp View 1 chunk +15 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/core/input/PointerEventManager.cpp View 1 chunk +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (4 generated)
Navid Zolghadr
Created Revert of Ignore pointer capture target while calculating click target
3 years, 9 months ago (2017-03-21 17:15:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2762913003/1
3 years, 9 months ago (2017-03-21 17:16:27 UTC) #4
commit-bot: I haz the power
3 years, 9 months ago (2017-03-21 19:24:15 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/1b708802860053bad35e8eaad250...

Powered by Google App Engine
This is Rietveld 408576698