Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(547)

Unified Diff: third_party/WebKit/Source/core/input/MouseEventManager.cpp

Issue 2755753003: Ignore pointer capture target while calculating click target (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/input/MouseEventManager.cpp
diff --git a/third_party/WebKit/Source/core/input/MouseEventManager.cpp b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
index 8649084de97f92988e9453a00c88478142c24961..7f318bb6d4043f62ed95606e6e22c489aa5e6dcc 100644
--- a/third_party/WebKit/Source/core/input/MouseEventManager.cpp
+++ b/third_party/WebKit/Source/core/input/MouseEventManager.cpp
@@ -251,38 +251,46 @@ WebInputEventResult MouseEventManager::dispatchMouseClickIfNeeded(
WebInputEventResult clickEventResult = WebInputEventResult::NotHandled;
const bool shouldDispatchClickEvent = m_clickCount > 0 && !contextMenuEvent &&
- target && m_clickNode &&
- target->canParticipateInFlatTree() &&
+ m_clickNode &&
m_clickNode->canParticipateInFlatTree();
if (shouldDispatchClickEvent) {
Node* clickTargetNode = nullptr;
// Updates distribution because a 'mouseup' event listener can make the
// tree dirty at dispatchMouseEvent() invocation above.
// Unless distribution is updated, commonAncestor would hit ASSERT.
- if (m_clickNode == target) {
- clickTargetNode = m_clickNode;
- clickTargetNode->updateDistribution();
- } else if (m_clickNode->document() == target->document()) {
- m_clickNode->updateDistribution();
- target->updateDistribution();
- clickTargetNode = target->commonAncestor(
- *m_clickNode, EventHandlingUtil::parentForClickEvent);
+ if (target && target->canParticipateInFlatTree()) {
+ if (m_clickNode == target) {
+ clickTargetNode = m_clickNode;
+ clickTargetNode->updateDistribution();
+ } else if (m_clickNode->document() == target->document()) {
+ m_clickNode->updateDistribution();
+ target->updateDistribution();
+ clickTargetNode = target->commonAncestor(
+ *m_clickNode, EventHandlingUtil::parentForClickEvent);
+ }
}
// This block is only for the purpose of gathering the metric and can be
// removed as soon as we don't need the metric.
if (targetWithoutCapture != target) {
Node* alternativeClickTargetNode = nullptr;
- if (m_clickNode == targetWithoutCapture) {
- alternativeClickTargetNode = m_clickNode;
- } else if (m_clickNode->document() == targetWithoutCapture->document()) {
- alternativeClickTargetNode = targetWithoutCapture->commonAncestor(
- *m_clickNode, EventHandlingUtil::parentForClickEvent);
+ if (targetWithoutCapture &&
+ targetWithoutCapture->canParticipateInFlatTree()) {
+ if (m_clickNode == targetWithoutCapture) {
+ alternativeClickTargetNode = m_clickNode;
+ } else if (m_clickNode->document() ==
+ targetWithoutCapture->document()) {
+ alternativeClickTargetNode = targetWithoutCapture->commonAncestor(
+ *m_clickNode, EventHandlingUtil::parentForClickEvent);
+ }
}
if (alternativeClickTargetNode != clickTargetNode) {
UseCounter::count(m_frame,
UseCounter::PointerEventClickRetargetCausedByCapture);
}
+ // TODO(crbug.com/699933): The following line removes the effect of
+ // pointer capture.
+ clickTargetNode = alternativeClickTargetNode;
}
if (clickTargetNode) {

Powered by Google App Engine
This is Rietveld 408576698