Change drawPicture calls to playback to avoid culling

Change drawPicture calls to playback to avoid culling

This patch (https://codereview.chromium.org/2690583002) changed
a number of SkPicture::playback calls to be PaintCanvas::drawPicture
calls.  However, drawPicture adds an extra clip, so if the rect
given to the SkPicture is incorrect then drawPicture will have
different behavior.

This patch (https://codereview.chromium.org/2743143002) fixed
one of these occurrences by fixing the rect.

This patch adds a temporary helper for playback to fix all of these
issues.

BUG=702577
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2755183002
Cr-Commit-Position: refs/heads/master@{#458528}
Committed: https://chromium.googlesource.com/chromium/src/+/2458d6d33ad666a16fa053063a872523c472acd4

[enne (OOO), 2017-03-17 19:02:46]

Description was changed from

==========
Change drawPicture calls to playback to avoid culling

This patch (https://codereview.chromium.org/2690583002) changed
a number of SkPicture::playback calls to be PaintCanvas::drawPicture
calls.  However, drawPicture adds an extra clip, so if the rect
given to the SkPicture is incorrect then drawPicture will have
different behavior.

This patch (https://codereview.chromium.org/2743143002) fixed
one of these occurrences by fixing the rect.

This patch adds a temporary helper for playback to fix all of these
issues.

BUG=702577
==========

to

==========
Change drawPicture calls to playback to avoid culling

This patch (https://codereview.chromium.org/2690583002) changed
a number of SkPicture::playback calls to be PaintCanvas::drawPicture
calls.  However, drawPicture adds an extra clip, so if the rect
given to the SkPicture is incorrect then drawPicture will have
different behavior.

This patch (https://codereview.chromium.org/2743143002) fixed
one of these occurrences by fixing the rect.

This patch adds a temporary helper for playback to fix all of these
issues.

BUG=702577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-17 19:02:46]

Description was changed from

==========
Change drawPicture calls to playback to avoid culling

This patch (https://codereview.chromium.org/2690583002) changed
a number of SkPicture::playback calls to be PaintCanvas::drawPicture
calls.  However, drawPicture adds an extra clip, so if the rect
given to the SkPicture is incorrect then drawPicture will have
different behavior.

This patch (https://codereview.chromium.org/2743143002) fixed
one of these occurrences by fixing the rect.

This patch adds a temporary helper for playback to fix all of these
issues.

BUG=702577
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change drawPicture calls to playback to avoid culling

This patch (https://codereview.chromium.org/2690583002) changed
a number of SkPicture::playback calls to be PaintCanvas::drawPicture
calls.  However, drawPicture adds an extra clip, so if the rect
given to the SkPicture is incorrect then drawPicture will have
different behavior.

This patch (https://codereview.chromium.org/2743143002) fixed
one of these occurrences by fixing the rect.

This patch adds a temporary helper for playback to fix all of these
issues.

BUG=702577
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-17 19:02:49]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-17 19:03:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-03-17 19:04:39]

enne@chromium.org changed reviewers:
+ danakj@chromium.org, pdr@chromium.org

[enne (OOO), 2017-03-17 19:05:06]

pdr: I tried! I fixed one of these rect issues, but now there are others.  So,
I'll just change them all back.

[commit-bot: I haz the power, 2017-03-17 20:33:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 20:33:57]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[enne (OOO), 2017-03-17 21:19:17]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[enne (OOO), 2017-03-17 21:19:23]

The CQ bit was unchecked by enne@chromium.org

[pdr., 2017-03-18 03:41:44]

On 2017/03/17 at 19:05:06, enne wrote:
> pdr: I tried! I fixed one of these rect issues, but now there are others.  So,
I'll just change them all back.

LGTM

The other issue you changed seemed like a real bug. Ae the newly found ones too?
If so, can file bug?

[danakj, 2017-03-20 14:53:55]

LGTM

https://codereview.chromium.org/2755183002/diff/1/cc/paint/paint_canvas.h
File cc/paint/paint_canvas.h (right):

https://codereview.chromium.org/2755183002/diff/1/cc/paint/paint_canvas.h#new...
cc/paint/paint_canvas.h:199: // TODO(enne): ideally this should live on
PaintRecord, but that's not
Or, more like this shouldn't exist really and PLS DONT USE IT and here's a bug
where we can delete this, and such?

https://codereview.chromium.org/2755183002/diff/1/cc/paint/paint_canvas.h#new...
cc/paint/paint_canvas.h:201: virtual void PlaybackPaintRecord(PaintRecord*
record) = 0;
Can it be an sk_sp<PaintRecord> like the drawPicture, that'll be less churn at
callers.

[enne (OOO), 2017-03-20 17:41:27]

On 2017/03/18 at 03:41:44, pdr wrote:
> On 2017/03/17 at 19:05:06, enne wrote:

> The other issue you changed seemed like a real bug. Ae the newly found ones
too? If so, can file bug?

Sure, filed and left a TODO.

https://codereview.chromium.org/2755183002/diff/1/cc/paint/paint_canvas.h
File cc/paint/paint_canvas.h (right):

https://codereview.chromium.org/2755183002/diff/1/cc/paint/paint_canvas.h#new...
cc/paint/paint_canvas.h:199: // TODO(enne): ideally this should live on
PaintRecord, but that's not
On 2017/03/20 at 14:53:54, danakj wrote:
> Or, more like this shouldn't exist really and PLS DONT USE IT and here's a bug
where we can delete this, and such?

The cleanup here is just moving one function from PaintCanvas to PaintRecord, so
it's not really something that needs a "don't use this because it'll make it
harder to remove later" sort of thing.  I think a TODO suffices, to be honest. 
Let me know if you disagree and I'll file a bug.

It's also not clear to me if that cleanup is the right thing to do? We kind of
want 3 things
(1) PaintRecord -> SkCanvas (raster)
(2) PaintRecord -> PaintCanvas (playback, flatten ops)
(3) PaintRecord -> PaintCanvas (drawPicture, if paint canvas is recording, then
just record an indirection instead of flattening)

I think #1 should live on PaintRecord.  #3 should live on PaintCanvas.  This
case is #2, and I could see it going either way.

https://codereview.chromium.org/2755183002/diff/1/cc/paint/paint_canvas.h#new...
cc/paint/paint_canvas.h:201: virtual void PlaybackPaintRecord(PaintRecord*
record) = 0;
On 2017/03/20 at 14:53:54, danakj wrote:
> Can it be an sk_sp<PaintRecord> like the drawPicture, that'll be less churn at
callers.

Done done done.

[enne (OOO), 2017-03-20 17:41:54]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-03-20 17:41:55]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2755183002/#ps20001
(title: "Address review comments")

[commit-bot: I haz the power, 2017-03-20 17:42:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:19:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-20 19:19:26]

Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[enne (OOO), 2017-03-21 17:08:33]

The CQ bit was checked by enne@chromium.org

[commit-bot: I haz the power, 2017-03-21 17:09:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 20:13:07]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490116113528090,
"parent_rev": "f9e8f9e6d60d8cd26c4239a377419cbb37fe8724", "commit_rev":
"2458d6d33ad666a16fa053063a872523c472acd4"}

[commit-bot: I haz the power, 2017-03-21 20:14:17]

Description was changed from

==========
Change drawPicture calls to playback to avoid culling

This patch (https://codereview.chromium.org/2690583002) changed
a number of SkPicture::playback calls to be PaintCanvas::drawPicture
calls.  However, drawPicture adds an extra clip, so if the rect
given to the SkPicture is incorrect then drawPicture will have
different behavior.

This patch (https://codereview.chromium.org/2743143002) fixed
one of these occurrences by fixing the rect.

This patch adds a temporary helper for playback to fix all of these
issues.

BUG=702577
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Change drawPicture calls to playback to avoid culling

This patch (https://codereview.chromium.org/2690583002) changed
a number of SkPicture::playback calls to be PaintCanvas::drawPicture
calls.  However, drawPicture adds an extra clip, so if the rect
given to the SkPicture is incorrect then drawPicture will have
different behavior.

This patch (https://codereview.chromium.org/2743143002) fixed
one of these occurrences by fixing the rect.

This patch adds a temporary helper for playback to fix all of these
issues.

BUG=702577
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2755183002
Cr-Commit-Position: refs/heads/master@{#458528}
Committed:
https://chromium.googlesource.com/chromium/src/+/2458d6d33ad666a16fa053063a87...
==========

[commit-bot: I haz the power, 2017-03-21 20:14:21]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2458d6d33ad666a16fa053063a87...