third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp - Issue 2755183002: Change drawPicture calls to playback to avoid culling

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

Issue 2755183002: Change drawPicture calls to playback to avoid culling (Closed)

Patch Set: Address review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/exported/WebScrollbarThemePainter.cpp ('k') | third_party/WebKit/Source/web/PageWidgetDelegate.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

index 3abcd1efe80bec62ffc7c065851f86cdb26c1691..cb9ce220648923bdbd243b3dd9e1461538967630 100644

--- a/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

+++ b/third_party/WebKit/Source/platform/graphics/RecordingImageBufferSurface.cpp

@@ -99,14 +99,14 @@ void RecordingImageBufferSurface::fallBackToRasterCanvas(

m_fallbackSurface->setImageBuffer(m_imageBuffer);

if (m_previousFrame) {

- m_fallbackSurface->canvas()->drawPicture(m_previousFrame);

+ m_fallbackSurface->canvas()->PlaybackPaintRecord(m_previousFrame);

m_previousFrame.reset();

}

if (m_currentFrame) {

sk_sp<PaintRecord> record = m_currentFrame->finishRecordingAsPicture();

if (record)

- m_fallbackSurface->canvas()->drawPicture(record);

+ m_fallbackSurface->canvas()->PlaybackPaintRecord(record);

m_currentFrame.reset();

}