Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Issue 2743143002: Fix incorrect print preview clipping (Closed)

Created:
3 years, 9 months ago by enne (OOO)
Modified:
3 years, 9 months ago
Reviewers:
pdr.
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix incorrect print preview clipping After https://codereview.chromium.org/2690583002 landed, it changed a number of SkPicture::playback calls to SkCanvas::drawPicture calls which also include a clip rect. (See link for reasons why.) WebLocalFrameImpl set an unscaled and untranslated SkPicture rect size, which caused pages that were not at the origin to be clipped. This patch adjusts the rect on the recorder so that pages are not accidentally culled. BUG=700305 Review-Url: https://codereview.chromium.org/2743143002 Cr-Commit-Position: refs/heads/master@{#456465} Committed: https://chromium.googlesource.com/chromium/src/+/3c66c935afbaa133537402a41bd619f79920d3ed

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 3 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (7 generated)
enne (OOO)
3 years, 9 months ago (2017-03-10 23:45:12 UTC) #3
pdr.
LGTM
3 years, 9 months ago (2017-03-10 23:48:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743143002/1
3 years, 9 months ago (2017-03-10 23:53:39 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/399087)
3 years, 9 months ago (2017-03-11 02:49:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2743143002/1
3 years, 9 months ago (2017-03-13 17:15:08 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-13 20:29:37 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/3c66c935afbaa133537402a41bd6...

Powered by Google App Engine
This is Rietveld 408576698