Change drawPicture calls to playback to avoid culling

cc/paint/paint_canvas.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CC_PAINT_PAINT_CANVAS_H_
 #define CC_PAINT_PAINT_CANVAS_H_
 
 #include "base/compiler_specific.h"
 #include "base/macros.h"
 #include "build/build_config.h"
@@ skipping 178 matching lines @@
 
   // For GraphicsContextCanvas only.  Maybe this could be rewritten?
   virtual void temporary_internal_describeTopLayer(SkMatrix* matrix,
                                                    SkIRect* clip_bounds) = 0;
 
   virtual bool ToPixmap(SkPixmap* output) = 0;
   virtual void AnnotateRectWithURL(const SkRect& rect, SkData* data) = 0;
   virtual void AnnotateNamedDestination(const SkPoint& point, SkData* data) = 0;
   virtual void AnnotateLinkToDestination(const SkRect& rect, SkData* data) = 0;
 
+  // TODO(enne): ideally this should live on PaintRecord, but that's not

[danakj, 2017/03/20 14:53:54]

Or, more like this shouldn't exist really and PLS DONT USE IT and here's a bug
where we can delete this, and such?

[enne (OOO), 2017/03/20 17:41:26]

The cleanup here is just moving one function from PaintCanvas to PaintRecord, so
it's not really something that needs a "don't use this because it'll make it
harder to remove later" sort of thing.  I think a TODO suffices, to be honest. 
Let me know if you disagree and I'll file a bug.

It's also not clear to me if that cleanup is the right thing to do? We kind of
want 3 things
(1) PaintRecord -> SkCanvas (raster)
(2) PaintRecord -> PaintCanvas (playback, flatten ops)
(3) PaintRecord -> PaintCanvas (drawPicture, if paint canvas is recording, then
just record an indirection instead of flattening)

I think #1 should live on PaintRecord.  #3 should live on PaintCanvas.  This
case is #2, and I could see it going either way.

+  // possible when PaintRecord is a typedef.
+  virtual void PlaybackPaintRecord(PaintRecord* record) = 0;

[danakj, 2017/03/20 14:53:54]

Can it be an sk_sp<PaintRecord> like the drawPicture, that'll be less churn at
callers.

[enne (OOO), 2017/03/20 17:41:26]

Done done done.

+
  protected:
   friend class PaintSurface;
   friend class PaintRecorder;
   friend CC_PAINT_EXPORT void PaintCanvasAnnotateRectWithURL(
       PaintCanvas* canvas,
       const SkRect& rect,
       SkData* data);
   friend CC_PAINT_EXPORT void PaintCanvasAnnotateNamedDestination(
       PaintCanvas* canvas,
       const SkPoint& point,
@@ skipping 57 matching lines @@
                                                          const SkPoint& point,
                                                          SkData* data);
 
 CC_PAINT_EXPORT void PaintCanvasAnnotateLinkToDestination(PaintCanvas* canvas,
                                                           const SkRect& rect,
                                                           SkData* data);
 
 }  // namespace cc
 
 #endif  // CC_PAINT_PAINT_CANVAS_H_