Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 2754263004: PPC: [Atomics] Make Atomics.exchange a builtin using TF (Closed)

Created:
3 years, 9 months ago by JaideepBajwa
Modified:
3 years, 8 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [Atomics] Make Atomics.exchange a builtin using TF Implemented l[w|h|b]arx and st[w|h|b]cx instructions which are needed to perform atomic exchange. Also added synchronization primitives similar to arm to simulate those instructions. R=joransiu@ca.ibm.com, jyan@ca.ibm.com, binji@chromium.org, aseemgarg@chromium.org BUG= Review-Url: https://codereview.chromium.org/2754263004 Cr-Commit-Position: refs/heads/master@{#44257} Committed: https://chromium.googlesource.com/v8/v8/+/f1ad374480ac9e75239ee076b3b757fa3e066641

Patch Set 1 #

Patch Set 2 : fix to the instr seq #

Patch Set 3 : rebased #

Patch Set 4 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+729 lines, -190 lines) Patch
M src/builtins/builtins-sharedarraybuffer-gen.cc View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M src/compiler/ppc/code-generator-ppc.cc View 1 2 3 2 chunks +22 lines, -0 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 1 chunk +33 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc.h View 1 2 3 5 chunks +18 lines, -1 line 0 comments Download
M src/ppc/assembler-ppc.cc View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M src/ppc/constants-ppc.h View 1 2 3 6 chunks +178 lines, -171 lines 0 comments Download
M src/ppc/disasm-ppc.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M src/ppc/simulator-ppc.h View 3 chunks +86 lines, -1 line 0 comments Download
M src/ppc/simulator-ppc.cc View 1 2 3 7 chunks +359 lines, -10 lines 0 comments Download

Messages

Total messages: 23 (14 generated)
JaideepBajwa
ptal
3 years, 9 months ago (2017-03-17 23:48:20 UTC) #1
john.yan
lgtm
3 years, 9 months ago (2017-03-20 17:36:08 UTC) #2
aseemgarg
lgtm
3 years, 9 months ago (2017-03-20 20:37:33 UTC) #3
aseemgarg
+Jaroslav
3 years, 9 months ago (2017-03-20 20:38:16 UTC) #6
JaideepBajwa
ping
3 years, 8 months ago (2017-03-30 01:00:10 UTC) #11
binji
lgtm
3 years, 8 months ago (2017-03-30 01:15:25 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2754263004/60001
3 years, 8 months ago (2017-03-30 03:04:02 UTC) #19
JaideepBajwa
On 2017/03/30 01:15:25, binji wrote: > lgtm thank you.
3 years, 8 months ago (2017-03-30 03:04:13 UTC) #20
commit-bot: I haz the power
3 years, 8 months ago (2017-03-30 03:05:24 UTC) #23
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/v8/v8/+/f1ad374480ac9e75239ee076b3b757fa3e0...

Powered by Google App Engine
This is Rietveld 408576698