DevTools: [regression] remote debugging to a tcp port does not work via chrome:inspect

DevTools: [regression] remote debugging to a tcp port does not work via chrome:inspect

BUG=702473
Review-Url: https://codereview.chromium.org/2752423002
Cr-Commit-Position: refs/heads/master@{#458191}
Committed: https://chromium.googlesource.com/chromium/src/+/9c08889d47139672b311b30e9075a57459a6ec86

[pfeldman, 2017-03-17 05:38:41]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org, eostroukhov@chromium.org

[eostroukhov, 2017-03-17 15:59:22]

lgtm

[dgozman, 2017-03-17 17:41:00]

Thank you for the fix! lgtm modulo comments

https://codereview.chromium.org/2752423002/diff/1/chrome/browser/devtools/dev...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/2752423002/diff/1/chrome/browser/devtools/dev...
chrome/browser/devtools/devtools_window.cc:501: frontend_type = kFrontendNode;
kFrontendV8

https://codereview.chromium.org/2752423002/diff/1/chrome/browser/devtools/dev...
chrome/browser/devtools/devtools_window.cc:942: if (frontend_url.empty())
This was checking remote_frontend before, not the frontend_url. Do they always
come together?

[pfeldman, 2017-03-20 19:30:23]

https://codereview.chromium.org/2752423002/diff/1/chrome/browser/devtools/dev...
File chrome/browser/devtools/devtools_window.cc (right):

https://codereview.chromium.org/2752423002/diff/1/chrome/browser/devtools/dev...
chrome/browser/devtools/devtools_window.cc:501: frontend_type = kFrontendNode;
On 2017/03/17 17:40:59, dgozman wrote:
> kFrontendV8

Ouch.

https://codereview.chromium.org/2752423002/diff/1/chrome/browser/devtools/dev...
chrome/browser/devtools/devtools_window.cc:942: if (frontend_url.empty())
On 2017/03/17 17:40:59, dgozman wrote:
> This was checking remote_frontend before, not the frontend_url. Do they always
> come together?

I renamed remote_frontend to frontend_url.

[pfeldman, 2017-03-20 20:30:53]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2017-03-20 20:30:53]

The patchset sent to the CQ was uploaded after l-g-t-m from
dgozman@chromium.org, eostroukhov@chromium.org
Link to the patchset: https://codereview.chromium.org/2752423002/#ps20001
(title: "review comment addressed.")

[commit-bot: I haz the power, 2017-03-20 20:31:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 21:25:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1490041853117540,
"parent_rev": "945ae95a9ba55102032f7e19a6dfe30af7ff3568", "commit_rev":
"9c08889d47139672b311b30e9075a57459a6ec86"}

[commit-bot: I haz the power, 2017-03-20 21:26:03]

Description was changed from

==========
DevTools: [regression] remote debugging to a tcp port does not work via
chrome:inspect

BUG=702473
==========

to

==========
DevTools: [regression] remote debugging to a tcp port does not work via
chrome:inspect

BUG=702473

Review-Url: https://codereview.chromium.org/2752423002
Cr-Commit-Position: refs/heads/master@{#458191}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c08889d47139672b311b30e9075...
==========

[commit-bot: I haz the power, 2017-03-20 21:26:04]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c08889d47139672b311b30e9075...