DevTools: [regression] remote debugging to a tcp port does not work via chrome:inspect

chrome/browser/devtools/devtools_window.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
 #define CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_
 
 #include "base/macros.h"
 #include "chrome/browser/devtools/devtools_contents_resizing_strategy.h"
 #include "chrome/browser/devtools/devtools_toggle_action.h"
@@ skipping 80 matching lines @@
   // scoped_refptr<content::DevToolsAgentHost> agent(
   //   content::DevToolsAgentHost::GetOrCreateFor(inspected_web_contents));
   // DevToolsWindow::ToggleDevToolsWindow(
   //   inspected_web_contents, DevToolsToggleAction::Show());
   // DevToolsWindow* window = DevToolsWindow::FindDevToolsWindow(agent.get());
   //
   static void ToggleDevToolsWindow(
       Browser* browser,
       const DevToolsToggleAction& action);
 
-  // External frontend is always undocked.
-  static void OpenExternalFrontend(
-      Profile* profile,
-      const std::string& frontend_uri,
-      const scoped_refptr<content::DevToolsAgentHost>& agent_host,
-      bool is_worker,
-      bool is_v8_only);
-
   // Node frontend is always undocked.
   static void OpenNodeFrontendWindow(Profile* profile);
 
   // Worker frontend is always undocked.
   static void OpenDevToolsWindowForWorker(
       Profile* profile,
       const scoped_refptr<content::DevToolsAgentHost>& worker_agent);
 
   static void InspectElement(content::RenderFrameHost* inspected_frame_host,
                              int x,
@@ skipping 119 matching lines @@
   // - CloseContents: destroys frontend;
   // - DevToolsWindow is dead once it's main_web_contents dies.
   enum LifeStage {
     kNotLoaded,
     kOnLoadFired, // Implies SetIsDocked was not yet called.
     kIsDockedSet, // Implies DocumentOnLoadCompleted was not yet called.
     kLoadCompleted,
     kClosing
   };
 
+  enum FrontendType {
+    kFrontendDefault,
+    kFrontendRemote,
+    kFrontendWorker,
+    kFrontendV8,
+    kFrontendNode
+  };
+
   DevToolsWindow(Profile* profile,
                  content::WebContents* main_web_contents,
                  DevToolsUIBindings* bindings,
                  content::WebContents* inspected_web_contents,
                  bool can_dock);
 
+  // External frontend is always undocked.
+  static void OpenExternalFrontend(
+      Profile* profile,
+      const std::string& frontend_uri,
+      const scoped_refptr<content::DevToolsAgentHost>& agent_host,
+      FrontendType frontend_type);
+
   static DevToolsWindow* Create(Profile* profile,
                                 content::WebContents* inspected_web_contents,
-                                bool shared_worker_frontend,
-                                bool v8_only_frontend,
-                                bool node_frontend,
-                                const std::string& remote_frontend,
+                                FrontendType frontend_type,
+                                const std::string& frontend_url,
                                 bool can_dock,
                                 const std::string& settings,
                                 const std::string& panel);
   static GURL GetDevToolsURL(Profile* profile,
-                             bool shared_worker_frontend,
-                             bool v8_only_frontend,
-                             bool node_frontend,
-                             const std::string& remote_frontend,
+                             FrontendType frontend_type,
+                             const std::string& frontend_url,
                              bool can_dock,
                              const std::string& panel);
 
   static DevToolsWindow* CreateDevToolsWindowForWorker(Profile* profile);
   static void ToggleDevToolsWindow(
       content::WebContents* web_contents,
       bool force_open,
       const DevToolsToggleAction& action,
       const std::string& settings);
 
@@ skipping 83 matching lines @@
   base::Closure ready_for_test_callback_;
 
   base::TimeTicks inspect_element_start_time_;
   std::unique_ptr<DevToolsEventForwarder> event_forwarder_;
 
   friend class DevToolsEventForwarder;
   DISALLOW_COPY_AND_ASSIGN(DevToolsWindow);
 };
 
 #endif  // CHROME_BROWSER_DEVTOOLS_DEVTOOLS_WINDOW_H_