Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3878)

Unified Diff: chrome/browser/ui/webui/devtools_ui.cc

Issue 2752423002: DevTools: [regression] remote debugging to a tcp port does not work via chrome:inspect (Closed)
Patch Set: review comment addressed. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/devtools_ui.cc
diff --git a/chrome/browser/ui/webui/devtools_ui.cc b/chrome/browser/ui/webui/devtools_ui.cc
index afafafeb7dbf1a59b17b3fa7b0c7be06b9cea5ae..f6869b87f92d26ea2073d128c4b8082841f74b4f 100644
--- a/chrome/browser/ui/webui/devtools_ui.cc
+++ b/chrome/browser/ui/webui/devtools_ui.cc
@@ -42,17 +42,6 @@ std::string PathWithoutParams(const std::string& path) {
const char kHttpNotFound[] = "HTTP/1.1 404 Not Found\n\n";
-#if BUILDFLAG(DEBUG_DEVTOOLS)
-// Local frontend url provided by InspectUI.
-const char kFallbackFrontendURL[] =
- "chrome-devtools://devtools/bundled/inspector.html";
-#else
-// URL causing the DevTools window to display a plain text warning.
-const char kFallbackFrontendURL[] =
- "data:text/plain,Cannot load DevTools frontend from an untrusted origin";
-#endif // BUILDFLAG(DEBUG_DEVTOOLS)
-
-
// DevToolsDataSource ---------------------------------------------------------
std::string GetMimeTypeForPath(const std::string& path) {
@@ -337,9 +326,8 @@ GURL DevToolsUI::GetProxyURL(const std::string& frontend_url) {
if (url.scheme() == content::kChromeDevToolsScheme &&
url.host() == chrome::kChromeUIDevToolsHost)
return GURL();
-
if (!url.is_valid() || url.host() != kRemoteFrontendDomain)
- return GURL(kFallbackFrontendURL);
+ return GURL();
return GURL(base::StringPrintf("%s://%s/%s/%s",
content::kChromeDevToolsScheme,
chrome::kChromeUIDevToolsHost,
« no previous file with comments | « chrome/browser/devtools/devtools_window.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698