Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(266)

Unified Diff: chrome/browser/devtools/devtools_window.h

Issue 2752423002: DevTools: [regression] remote debugging to a tcp port does not work via chrome:inspect (Closed)
Patch Set: review comment addressed. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_window.h
diff --git a/chrome/browser/devtools/devtools_window.h b/chrome/browser/devtools/devtools_window.h
index 6042d14e97b1b59c3b2890cf93d5a6064559dd14..9281682277edfb3e11848bc63152a8294e33f72d 100644
--- a/chrome/browser/devtools/devtools_window.h
+++ b/chrome/browser/devtools/devtools_window.h
@@ -98,14 +98,6 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
Browser* browser,
const DevToolsToggleAction& action);
- // External frontend is always undocked.
- static void OpenExternalFrontend(
- Profile* profile,
- const std::string& frontend_uri,
- const scoped_refptr<content::DevToolsAgentHost>& agent_host,
- bool is_worker,
- bool is_v8_only);
-
// Node frontend is always undocked.
static void OpenNodeFrontendWindow(Profile* profile);
@@ -245,26 +237,37 @@ class DevToolsWindow : public DevToolsUIBindings::Delegate,
kClosing
};
+ enum FrontendType {
+ kFrontendDefault,
+ kFrontendRemote,
+ kFrontendWorker,
+ kFrontendV8,
+ kFrontendNode
+ };
+
DevToolsWindow(Profile* profile,
content::WebContents* main_web_contents,
DevToolsUIBindings* bindings,
content::WebContents* inspected_web_contents,
bool can_dock);
+ // External frontend is always undocked.
+ static void OpenExternalFrontend(
+ Profile* profile,
+ const std::string& frontend_uri,
+ const scoped_refptr<content::DevToolsAgentHost>& agent_host,
+ FrontendType frontend_type);
+
static DevToolsWindow* Create(Profile* profile,
content::WebContents* inspected_web_contents,
- bool shared_worker_frontend,
- bool v8_only_frontend,
- bool node_frontend,
- const std::string& remote_frontend,
+ FrontendType frontend_type,
+ const std::string& frontend_url,
bool can_dock,
const std::string& settings,
const std::string& panel);
static GURL GetDevToolsURL(Profile* profile,
- bool shared_worker_frontend,
- bool v8_only_frontend,
- bool node_frontend,
- const std::string& remote_frontend,
+ FrontendType frontend_type,
+ const std::string& frontend_url,
bool can_dock,
const std::string& panel);
« no previous file with comments | « no previous file | chrome/browser/devtools/devtools_window.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698