Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op,
NOTREACHED, CHECK_op respectively.

BUG=697692
Review-Url: https://codereview.chromium.org/2751483005
Cr-Commit-Position: refs/heads/master@{#458439}
Committed: https://chromium.googlesource.com/chromium/src/+/93578226fe0366d00cf97b5e588e51ff1cd56885

[Hwanseung Lee, 2017-03-15 13:39:06]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 13:39:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 13:48:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 13:48:13]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)

[Hwanseung Lee, 2017-03-15 13:57:59]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 13:58:10]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 14:07:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 14:07:42]

Dry run: Try jobs failed on following builders:
  chromeos_amd64-generic_chromium_compile_only_ng on
master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)

[Hwanseung Lee, 2017-03-15 14:11:40]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 14:11:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 14:29:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 14:29:18]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Hwanseung Lee, 2017-03-15 14:34:39]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 14:34:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 15:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 15:54:19]

Dry run: This issue passed the CQ dry run.

[Hwanseung Lee, 2017-03-15 23:57:13]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op,
NOTREACHED, CHECK_op respectively.

BUG=697692
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op,
NOTREACHED, CHECK_op respectively.

BUG=697692
==========

[Hwanseung Lee, 2017-03-15 23:57:13]

hs1217.lee@samsung.com changed reviewers:
+ kouhei@chromium.org, tkent@chromium.org

[Hwanseung Lee, 2017-03-15 23:57:37]

PTAL, thank you.

[Yoav Weiss, 2017-03-16 10:24:43]

yoav@yoav.ws changed reviewers:
+ yoav@yoav.ws

[Yoav Weiss, 2017-03-16 10:24:44]

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp
(right):

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp:87: #if
DCHECK_IS_ON()
Why the macro here?

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp (right):

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp:2722: #if
DCHECK_IS_ON()
Again, why the extra "#if"?

[Hwanseung Lee, 2017-03-16 12:34:02]

@Yoav Weiss.
i left comments. could you check it? thank you.

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp
(right):

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp:88:
DCHECK(!checkpoint.isNull());
it is cause of build fail without "#if DCHECK_IS_ON()"
isNull() function was defined at inside "#if DCHECK_IS_ON()"
refer to blew link.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/pars...

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp (right):

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/HTMLTreeBuilder.cpp:2722: #if
DCHECK_IS_ON()
On 2017/03/16 10:24:44, Yoav Weiss wrote:
> Again, why the extra "#if"?

it is cause of build fail without "#if DCHECK_IS_ON()"
m_isAttached was defined at inside "#if DCHECK_IS_ON()"
refer to below link.
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/html/pars...

[kouhei (in TOK), 2017-03-16 12:47:22]

kouhei@chromium.org changed reviewers:
+ dominicc@chromium.org

[kouhei (in TOK), 2017-03-16 12:47:23]

+dominicc: Do you know if we still have stack size regression from DCHECKs?

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp
(right):

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp:84:
.size());  // If this ASSERT fires, checkpointIndex is invalid.
Would you fix formatting here? Also, would you convert comment to DCHECK err
msg?

[Hwanseung Lee, 2017-03-16 14:28:44]

The CQ bit was checked by hs1217.lee@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 14:29:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hwanseung Lee, 2017-03-16 14:29:54]

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp
(right):

https://codereview.chromium.org/2751483005/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/parser/BackgroundHTMLInputStream.cpp:84:
.size());  // If this ASSERT fires, checkpointIndex is invalid.
On 2017/03/16 12:47:23, kouhei wrote:
> Would you fix formatting here? Also, would you convert comment to DCHECK err
> msg?

i tried to change formatting. but i can't change formatting.
when use "git cl format", it was restored as present status.
when 84 line raise to 83 line, that line is over 80 characters. 

and "ASSERT" had changed to "DCHECK" in comment.

[commit-bot: I haz the power, 2017-03-16 16:10:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 16:10:38]

Dry run: This issue passed the CQ dry run.

[dominicc (has gone to gerrit), 2017-03-19 23:04:45]

On 2017/03/16 at 12:47:23, kouhei wrote:
> +dominicc: Do you know if we still have stack size regression from DCHECKs?

AFAIK dcheng fixed this here:
<https://chromium.googlesource.com/chromium/src/+/b6026eb7489ef89100fd8126b2a5...>

[Hwanseung Lee, 2017-03-21 09:34:14]

@Yoav, kouhei
PTAL, thank you.

[Yoav Weiss, 2017-03-21 09:37:48]

On 2017/03/21 09:34:14, Hwanseung Lee wrote:
> @Yoav, kouhei
> PTAL, thank you.

LGTM

[kouhei (in TOK), 2017-03-21 11:54:11]

lgtm

[Hwanseung Lee, 2017-03-21 15:07:05]

The CQ bit was checked by hs1217.lee@samsung.com

[commit-bot: I haz the power, 2017-03-21 15:07:25]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 15:09:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-21 15:09:59]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Hwanseung Lee, 2017-03-21 15:19:14]

The CQ bit was checked by hs1217.lee@samsung.com

[Hwanseung Lee, 2017-03-21 15:19:15]

The patchset sent to the CQ was uploaded after l-g-t-m from yoav@yoav.ws,
kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2751483005/#ps100001
(title: "rebase")

[commit-bot: I haz the power, 2017-03-21 15:19:33]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-21 16:50:24]

CQ is committing da patch.

Bot data: {"patchset_id": 100001, "attempt_start_ts": 1490109554922270,
"parent_rev": "cc65a6c44dc84e130f0d3f01e41d92afc93fb229", "commit_rev":
"93578226fe0366d00cf97b5e588e51ff1cd56885"}

[commit-bot: I haz the power, 2017-03-21 16:52:17]

Description was changed from

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op,
NOTREACHED, CHECK_op respectively.

BUG=697692
==========

to

==========
Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT with DCHECK_op,
NOTREACHED, CHECK_op respectively.

BUG=697692

Review-Url: https://codereview.chromium.org/2751483005
Cr-Commit-Position: refs/heads/master@{#458439}
Committed:
https://chromium.googlesource.com/chromium/src/+/93578226fe0366d00cf97b5e588e...
==========

[commit-bot: I haz the power, 2017-03-21 16:52:18]

Committed patchset #6 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/93578226fe0366d00cf97b5e588e...