third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp - Issue 2751483005: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

Issue 2751483005: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/ (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScanner.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLSourceTracker.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

index 3128d7f632741935a7629dae3d3e1502ba904760..edcd3ec90f7784180cec7f3b38b004a54860a3f9 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloader.cpp

@@ -58,8 +58,8 @@ int HTMLResourcePreloader::countPreloads() {

static void preconnectHost(PreloadRequest* request,

const NetworkHintsInterface& networkHintsInterface) {

- ASSERT(request);

- ASSERT(request->isPreconnect());

+ DCHECK(request);

+ DCHECK(request->isPreconnect());

KURL host(request->baseURL(), request->resourceURL());

if (!host.isValid() || !host.protocolIsInHTTPFamily())

return;