third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h - Issue 2751483005: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h

Issue 2751483005: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/ (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLEntitySearch.cpp ('k') | third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h b/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h

index 010b8808d6fabce8deaa529b9bde24599be1d217..1444077dc7a4a73479898427e4ff484acd5b77d7 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h

+++ b/third_party/WebKit/Source/core/html/parser/HTMLFormattingElementList.h

@@ -63,7 +63,7 @@ class HTMLFormattingElementList {

Element* element() const {

// The fact that !m_item == isMarker() is an implementation detail callers

// should check isMarker() before calling element().

- ASSERT(m_item);

+ DCHECK(m_item);

return m_item->element();

}

void replaceElement(HTMLStackItem* item) { m_item = item; }