third_party/WebKit/Source/core/html/parser/HTMLStackItem.h - Issue 2751483005: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLStackItem.h

Issue 2751483005: Replace ASSERT, ASSERT_NOT_REACHED, and RELEASE_ASSERT in core/html/parser/ (Closed)

Patch Set: rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/HTMLStackItem.h

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLStackItem.h b/third_party/WebKit/Source/core/html/parser/HTMLStackItem.h

index 68fd85be29ebb8d88aa2fb436a3f62be6afe20b7..9fd928027f9c89810cc348d8187adf61a0137779 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLStackItem.h

+++ b/third_party/WebKit/Source/core/html/parser/HTMLStackItem.h

@@ -65,11 +65,11 @@ class HTMLStackItem : public GarbageCollectedFinalized<HTMLStackItem> {

const AtomicString& localName() const { return m_tokenLocalName; }

const Vector<Attribute>& attributes() const {

- ASSERT(m_tokenLocalName);

+ DCHECK(m_tokenLocalName);

return m_tokenAttributes;

}

Attribute* getAttributeItem(const QualifiedName& attributeName) {

- ASSERT(m_tokenLocalName);

+ DCHECK(m_tokenLocalName);

return findAttributeInVector(m_tokenAttributes, attributeName);

}