Report UseCounter metric when observing NotDef glyphs

Report new UseCounter metric when observing NotDef glyphs

When shaping fails to find at least one glyph, report this as a new
UseCounter metric "FontShapingNotDefGlyphObserved" for the current
document, which we can access via FontSelector. Measuring it as a ratio
against all UseCounter events should help us evaluate how frequently
.notdef glyphs occur in general. A separate histogram to be added later
will help find out for which characters or graphemes specifically we
fail to find glyphs for.

BUG=699578
Review-Url: https://codereview.chromium.org/2751163002
Cr-Commit-Position: refs/heads/master@{#470917}
Committed: https://chromium.googlesource.com/chromium/src/+/a3976985653410d2d753c268f8085873b6ed4a56

[drott, 2017-03-15 17:40:08]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[drott, 2017-03-15 17:40:44]

drott@chromium.org changed reviewers:
+ eae@chromium.org, jochen@chromium.org, kojii@chromium.org, mkwst@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:40:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-15 18:55:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 18:55:01]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Mike West, 2017-03-16 06:07:11]

The crashes look relevant. :)

Adding the use counter and the associated histogram entry LGTM, but please ask
someone who knows things about fonts to sanity check the logic.

[drott, 2017-03-16 07:56:30]

On 2017/03/16 at 06:07:11, mkwst wrote:
> The crashes look relevant. :)
> Adding the use counter and the associated histogram entry LGTM, but please ask
someone who knows things about fonts to sanity check the logic.

True, that'd be me ;-) I'll check the crashes.

[eae, 2017-03-16 22:28:37]

LGTM

[drott, 2017-03-21 18:05:12]

Description was changed from

==========
Report new UseCounter metric when observing NotDef glyphs

When shaping fails to find at least one glyph, report this as a new
UseCounter metric "FontShapingNotDefGlyphObserved" for the current
document, which we can access via FontSelector. Measuring it as a ratio
against all UseCounter events should help us evaluate how frequently
.notdef glyphs occur in general. A separate histogram to be added later
will help find out for which characters or graphemes specifically we
fail to find glyphs.

BUG=699578
==========

to

==========
Report new UseCounter metric when observing NotDef glyphs

When shaping fails to find at least one glyph, report this as a new
UseCounter metric "FontShapingNotDefGlyphObserved" for the current
document, which we can access via FontSelector. Measuring it as a ratio
against all UseCounter events should help us evaluate how frequently
.notdef glyphs occur in general. A separate histogram to be added later
will help find out for which characters or graphemes specifically we
fail to find glyphs for.

BUG=699578
==========

[jochen (gone - plz use gerrit), 2017-03-22 10:01:57]

I guess with Mike's and Emil's review you're already covered?

[drott, 2017-03-22 15:06:22]

On 2017/03/22 at 10:01:57, jochen wrote:
> I guess with Mike's and Emil's review you're already covered?

Thanks, yes, although I need to figure out why sometimes there is no
fontselector object, and resolve those crashes.

[drott, 2017-05-08 14:10:10]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 14:10:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[drott, 2017-05-08 14:18:23]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-08 14:18:46]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-08 17:18:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-08 17:18:57]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[drott, 2017-05-10 09:43:14]

The CQ bit was checked by drott@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-10 09:43:57]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[szager1, 2017-05-10 09:51:16]

szager@chromium.org changed reviewers:
+ szager@chromium.org

[szager1, 2017-05-10 09:51:17]

lgtm

[drott, 2017-05-10 09:51:34]

The CQ bit was unchecked by drott@chromium.org

[drott, 2017-05-10 09:51:36]

The CQ bit was checked by drott@chromium.org

[drott, 2017-05-10 09:51:37]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
mkwst@chromium.org
Link to the patchset: https://codereview.chromium.org/2751163002/#ps60001
(title: "Relax num_glyphs assertion, not feasible on Mac")

[commit-bot: I haz the power, 2017-05-10 09:52:14]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 12:56:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 12:56:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2017-05-10 15:03:24]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-05-10 15:04:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-10 17:41:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-10 17:41:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[drott, 2017-05-11 08:42:45]

The CQ bit was checked by drott@chromium.org

[commit-bot: I haz the power, 2017-05-11 08:43:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-11 11:24:02]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1494492165730520,
"parent_rev": "c16f9ff9695525a663e586c269685624e403d674", "commit_rev":
"a3976985653410d2d753c268f8085873b6ed4a56"}

[commit-bot: I haz the power, 2017-05-11 11:24:17]

Description was changed from

==========
Report new UseCounter metric when observing NotDef glyphs

When shaping fails to find at least one glyph, report this as a new
UseCounter metric "FontShapingNotDefGlyphObserved" for the current
document, which we can access via FontSelector. Measuring it as a ratio
against all UseCounter events should help us evaluate how frequently
.notdef glyphs occur in general. A separate histogram to be added later
will help find out for which characters or graphemes specifically we
fail to find glyphs for.

BUG=699578
==========

to

==========
Report new UseCounter metric when observing NotDef glyphs

When shaping fails to find at least one glyph, report this as a new
UseCounter metric "FontShapingNotDefGlyphObserved" for the current
document, which we can access via FontSelector. Measuring it as a ratio
against all UseCounter events should help us evaluate how frequently
.notdef glyphs occur in general. A separate histogram to be added later
will help find out for which characters or graphemes specifically we
fail to find glyphs for.

BUG=699578

Review-Url: https://codereview.chromium.org/2751163002
Cr-Commit-Position: refs/heads/master@{#470917}
Committed:
https://chromium.googlesource.com/chromium/src/+/a3976985653410d2d753c268f808...
==========

[commit-bot: I haz the power, 2017-05-11 11:24:19]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/a3976985653410d2d753c268f808...