third_party/WebKit/Source/platform/fonts/FontSelector.h - Issue 2751163002: Report UseCounter metric when observing NotDef glyphs

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/platform/fonts/FontSelector.h

Issue 2751163002: Report UseCounter metric when observing NotDef glyphs (Closed)

Patch Set: Relax num_glyphs assertion, not feasible on Mac Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.	2 * Copyright (C) 2007, 2008 Apple Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions	5 * modification, are permitted provided that the following conditions

6 * are met:	6 * are met:

7 * 1. Redistributions of source code must retain the above copyright	7 * 1. Redistributions of source code must retain the above copyright

8 * notice, this list of conditions and the following disclaimer.	8 * notice, this list of conditions and the following disclaimer.

9 * 2. Redistributions in binary form must reproduce the above copyright	9 * 2. Redistributions in binary form must reproduce the above copyright

10 * notice, this list of conditions and the following disclaimer in the	10 * notice, this list of conditions and the following disclaimer in the

(...skipping 36 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
47 // TODO crbug.com/542629 - The String variant of this method shouldbe replaced	47 // TODO crbug.com/542629 - The String variant of this method shouldbe replaced

48 // with a better approach, now that we only have complex text.	48 // with a better approach, now that we only have complex text.

49 virtual void WillUseFontData(const FontDescription&,	49 virtual void WillUseFontData(const FontDescription&,

50 const AtomicString& family_name,	50 const AtomicString& family_name,

51 const String& text) = 0;	51 const String& text) = 0;

52 virtual void WillUseRange(const FontDescription&,	52 virtual void WillUseRange(const FontDescription&,

53 const AtomicString& family_name,	53 const AtomicString& family_name,

54 const FontDataForRangeSet&) = 0;	54 const FontDataForRangeSet&) = 0;

55	55

56 virtual unsigned Version() const = 0;	56 virtual unsigned Version() const = 0;

	57

	58 virtual void ReportNotDefGlyph() const = 0;

57 };	59 };

58	60

59 } // namespace blink	61 } // namespace blink

60	62

61 #endif // FontSelector_h	63 #endif // FontSelector_h

OLD	NEW